Sorry to bug you all, but is there anyone who can take a look at this and issue 3312? It's blocking deployment of Review Board at Mozilla. If we can't figure this out, we're going to have to come up with a totally different approach.
Thanks, Mark On Wednesday, 11 June 2014 14:55:54 UTC-4, George Miroshnykov wrote: > > Hi Christian, > > Thanks for your help! > > I'm trying to generate a squashed diff of multiple commits by specifying > first and last commits like this: > hg diff --rev 'f0c92cb17217::5db37ca696a4' > > Adding the --git flag doesn't change the output. > > Is there a way to create review requests based on such diffs? > > On Tuesday, June 10, 2014 11:29:15 PM UTC+3, Christian Hammond wrote: >> >> Hi George, >> >> The base_commit_id is just one piece of what we use to fetch file >> contents, and it’s really only used for certain repo hosting services we >> support (like Bitbucket) due to their API requirements. It does not work >> with plain Mercurial repositories. >> >> The diffs really need to contain revision info for the files in order to >> fetch them. >> >> How are these diffs being built? Why don’t they contain that information? >> >> Christian >> >> -- >> Christian Hammond - [email protected] >> Review Board - http://www.reviewboard.org >> Beanbag, Inc. - http://www.beanbaginc.com >> >> On June 10, 2014 at 11:22:26 AM, George Miroshnykov ([email protected]) >> wrote: >> >> Hello, >> >> I'm using Mercurial repository and I'd like to post a raw diff like this >> one: >> >> diff --git a/README.md b/README.md >> --- a/README.md >> +++ b/README.md >> @@ -1,3 +1,5 @@ >> Commits: >> >> * First commit >> +* Second commit >> +* Third commit >> >> >> You can see that it doesn't have any info about base commit ID. >> So in order to post it, I have to explicitly tell RB the base commit >> against which this diff should be applied. >> >> As per docs: >> >> http://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/draft-diff/#fields >> I though I could use base_commit_id field to do that, but that doesn't >> seem to work, see this bug: >> https://code.google.com/p/reviewboard/issues/detail?id=3312 >> >> Am I doing something wrong here? >> Is there an easy way to do what I'm trying to do without using RBTools? >> >> Thanks, >> George >> >> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> >> -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
