Actually, I've managed to build a case into our unit tests. We'll get this
fixed for 2.0.3.

Thanks!
-David


On Thu, Jul 3, 2014 at 12:27 PM, David Trowbridge <trowb...@gmail.com>
wrote:

> Would you be willing to apply a patch to your server and test it for us? I
> haven't been able to nail down a solid reproduction case for this.
>
> -David
>
>
> On Thu, Jul 3, 2014 at 4:50 AM, c mu <cmu.tr...@gmail.com> wrote:
>
>>  Hi there,
>>
>> I upgraded to 2.0.2 from 1.6.11. If I want to view the diff of some
>> reviews, I get the following error
>>
>>
>> Can anyone help me to solve this?
>>
>>
>> thank you!
>>
>>
>> #################################################################
>>
>> There was an error displaying this diff.
>>
>>
>> 'ascii' codec can't decode byte 0xdc in position 2949: ordinal not in
>> range(128)
>>
>>
>> This may be a bug in the software, a temporary outage, or an issue with
>> the format of your diff.
>>
>>
>> Please try again, and if you still have trouble, contact support.
>>
>>
>> Details
>>
>> Traceback (most recent call last):
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
>> line 236, in get
>>
>>    renderer = self.create_renderer(context, *args, **kwargs)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py",
>> line 1111, in create_renderer
>>
>>    *args, **kwargs)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
>> line 326, in create_renderer
>>
>>    self.diff_file = self._get_requested_diff_file()
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
>> line 367, in _get_requested_diff_file
>>
>>    request=self.request)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>> line 373, in populate_diff_chunks
>>
>>    chunks = generator.get_chunks()
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>> line 148, in get_chunks
>>
>>    large_data=True)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py",
>> line 109, in cache_memoize
>>
>>    data = lookup_callable()
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>> line 147, in <lambda>
>>
>>    lambda: list(self._get_chunks_uncached()),
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>> line 154, in _get_chunks_uncached
>>
>>    old = get_original_file(self.filediff, self.request, encoding_list)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>> line 169, in get_original_file
>>
>>    request=request)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/models.py",
>> line 220, in get_file
>>
>>    large_data=True)[0]
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py",
>> line 109, in cache_memoize
>>
>>    data = lookup_callable()
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/models.py",
>> line 219, in <lambda>
>>
>>    request)],
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/models.py",
>> line 379, in _get_file_uncached
>>
>>    data = self.get_scmtool().get_file(path, revision)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/svn/__init__.py",
>> line 117, in get_file
>>
>>    return self.client.get_file(path, revision)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>> line 106, in get_file
>>
>>    return self._do_on_path(self._get_file_data, path, revision)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>> line 72, in _do_on_path
>>
>>    return cb(normpath, normrev)
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>> line 100, in _get_file_data
>>
>>    data = self.collapse_keywords(data, keywords[normpath])
>>
>>  File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/svn/base.py",
>> line 118, in collapse_keywords
>>
>>    repl, data)
>>
>>  File "/usr/lib/python2.7/re.py", line 151, in sub
>>
>>    return _compile(pattern, flags).sub(repl, string, count)
>>
>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xdc in position
>> 2949: ordinal not in range(128)
>>
>> --
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to