That looks very strange. Looks like there may be a bug here.

What happens if, from the server and with your login information, you run:

    p4 print -q //depot/path/to/file#revision

Where the path and revision come from that diff.

Also, is that file blank in the repository?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 7, 2014 at 1:12:29 PM, Stephen (srma...@gmail.com) wrote:


Oh OK, well I've been able to refine the procedure and I now have RB 2.0.2 up 
and running with the old database.
I have been able to log into the admin dashboard and update the Perforce 
repository details which has allowed me to rbt post a new review (0.6.2).

However when I look at the diffs from an old review that is open I get the 
error:

There was an error displaying this diff.

(u'Value to convert is unexpected type %s', <type 'NoneType'>)

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

Please try again, and if you still have trouble, contact support.

Details
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 236, in get
    renderer = self.create_renderer(context, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py",
 line 1111, in create_renderer
    *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 326, in create_renderer
    self.diff_file = self._get_requested_diff_file()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 367, in _get_requested_diff_file
    request=self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 373, in populate_diff_chunks
    chunks = generator.get_chunks()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 148, in get_chunks
    large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py",
 line 109, in cache_memoize
    data = lookup_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 147, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 154, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request, encoding_list)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 172, in get_original_file
    encoding, data = convert_to_unicode(data, encoding_list)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 65, in convert_to_unicode
    raise TypeError('Value to convert is unexpected type %s', type(s))
TypeError: (u'Value to convert is unexpected type %s', <type 'NoneType'>)


All the files in the review have this error. Any ideas?

A second error scenario shows up for a newly posted review:

There was an error displaying this diff.

The patch to '//<path_removed>/hwresourcecalc.c' didn't apply cleanly. The 
temporary files have been left in '/tmp/reviewboard.og0LPk' for debugging 
purposes. `patch` returned:

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

Please try again, and if you still have trouble, contact support.

Details
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 236, in get
    renderer = self.create_renderer(context, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py",
 line 1111, in create_renderer
    *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 326, in create_renderer
    self.diff_file = self._get_requested_diff_file()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py",
 line 367, in _get_requested_diff_file
    request=self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 373, in populate_diff_chunks
    chunks = generator.get_chunks()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 148, in get_chunks
    large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py",
 line 109, in cache_memoize
    data = lookup_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 147, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 line 155, in _get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 201, in get_patched_file
    return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 line 139, in patch
    'output': stderr,
Exception: The patch to '//<path_removed>/hwresourcecalc.c' didn't apply 
cleanly. The temporary files have been left in '/tmp/reviewboard.og0LPk' for 
debugging purposes.
`patch` returned:  


The /tmp/reviewboard.og0LPk folder shows the following (unable to share the 
content of the files):

The total 16
drwxrwxrwx  2 www-data www-data 4096 Jul  7 21:05 ./
drwxrwxrwt 16 root     root     4096 Jul  7 21:05 ../
-rw-r--r--  1 www-data www-data  547 Jul  7 21:05 hwresourcecalc.c.diff
-rw-------  1 www-data www-data    0 Jul  7 21:05 tmp59dOmO
-rw-------  1 www-data www-data    0 Jul  7 21:05 tmp59dOmO-new
-rw-------  1 www-data www-data  422 Jul  7 21:05 tmp59dOmO-new.rej

Any ideas on either would be most welcome.

Thanks,
Stephen.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to