Thanks David,

I did more debugging.
cmvc.py has the function:

    def get_file(self, path, revision=HEAD):
                logging.debug("CMVC File invoked  %s %s" % (filename, 
revision ))
                if not path:
                        raise FileNotFoundError(path, revision)
                return self.client.cat_file(path, revision)


I also added debug statement, but the log file is not having any custom 
defined debug entries. Does it mean that function is not invoked?
At line, 100 od diffutils.py code is related to old file
    (fd, oldfile) = tempfile.mkstemp(dir=tempdir)
    f = os.fdopen(fd, "w+b")
    f.write(convert_line_endings(file))
    f.close()

But here, I dont see in the logs related to custom module debug messages.
Next to that, it is doing patch and then expetion is raised.

Logs:
2014-09-13 01:57:14,292 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Generating diff file info for diffset id 5, filediff 5 took 0.003863 
seconds
2014-09-13 01:57:14,292 - DEBUG -  - Cache miss for key 
diff-sidebyside-hl-5-en.
2014-09-13 01:57:14,295 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Begin: Patching file testfile
2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- End: Patching file testfile
2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Patching file testfile took 0.012399 seconds
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Begin: Generating diff file info for diffset id 5, filediff 5
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- End: Generating diff file info for diffset id 5, filediff 5
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Generating diff file info for diffset id 5, filediff 5 took 0.000472 
seconds


Pls. help to resolve the issue.

Thanks,
Jes






On Sunday, September 14, 2014 11:48:20 PM UTC+5:30, David Trowbridge wrote:
>
> You should not be looking at the RBTools code for this. RBTools is for the 
> client-side command line tools.
>
> The server-side code for communicating with repositories lives in 
> reviewboard/scmtools. The function for returning the original version of 
> the file is called get_file().
>
> -David
>
>
>
> On Sun, Sep 14, 2014 at 11:15 AM, <ch.je...@gmail.com <javascript:>> 
> wrote:
>
>> Thanks David.
>> I tried to go through all supported clients like CVS/ClearCase(class 
>> CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)
>>
>> Which function in this class is really returning the original version or 
>> modified version of file.
>> From all the Client classes, I could see that diff function is overwitten 
>> and it is returing the difference between files.
>> But which is the function that returns the original/modified file?
>>
>> Also post-review or rbt post is not used with revisions in the 
>> customnized CMVC client, hence no need to have parse_revision_spec and
>> need not consider revisions right? It would also have revisions as zero.
>>
>> Pls. help, which class can be taken as a reference to fix issues with 
>> customized class.
>> tmppg8GFU should contain original file and tmppg8GFU.new should contain 
>> modified file?
>>
>> Thanks,
>> Jes. 
>>  
>>
>> On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge wrote:
>>>
>>> The tmppg8GFU file should be the original version of the file being 
>>> patched. Given that this is empty, I believe that there is a bug in your 
>>> cvmc SCMTool implementation.
>>>
>>> -David
>>>
>>> On Sat, Sep 13, 2014 at 10:23 AM, <ch.je...@gmail.com> wrote:
>>>
>>>> Hi David,
>>>> IT is a customized control system, cmvc.
>>>>
>>>> Diff is properly generated in the debug files. tmppg8GFU-new.rej file 
>>>> and test.diff.
>>>>
>>>> But it is unable to post the diff to server. Screen is showing 
>>>> following error:
>>>>
>>>>
>>>> Traceback (most recent call last):
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>  line 236, in get
>>>>     renderer = self.create_renderer(context, *args, **kwargs)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py",
>>>>  line 1088, in create_renderer
>>>>     *args, **kwargs)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>  line 328, in create_renderer
>>>>     self.diff_file = self._get_requested_diff_file()
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>  line 369, in _get_requested_diff_file
>>>>     request=self.request)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>  line 373, in populate_diff_chunks
>>>>     chunks = generator.get_chunks()
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>  line 153, in get_chunks
>>>>     large_data=True)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py",
>>>>  line 109, in cache_memoize
>>>>     data = lookup_callable()
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>  line 152, in <lambda>
>>>>     lambda: list(self._get_chunks_uncached()),
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>  line 160, in _get_chunks_uncached
>>>>     new = get_patched_file(old, self.filediff, self.request)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>  line 201, in get_patched_file
>>>>     return patch(diff, buffer, filediff.dest_file, request)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>  line 139, in patch
>>>>     'output': stderr,
>>>> Exception: The patch to 'test' didn't apply cleanly. The temporary files 
>>>> have been left in '/tmp/reviewboard.axR11W' for debugging purposes.
>>>> `patch` returned: 
>>>>
>>>>
>>>> what is the meaning of patch error?
>>>> How to resolve this?
>>>> tmppg8GFU and tmppg8GFU-new files are empty in the debug directory.
>>>> what supposed be contents of these files?
>>>> Pls. help
>>>>
>>>> Thanks,
>>>> Jes .
>>>>
>>>>
>>>> On Saturday, September 13, 2014 3:25:42 AM UTC+5:30, David Trowbridge 
>>>> wrote:
>>>>>
>>>>> Is the tmppg8GFU file what you'd expect? (the pre-patched file 
>>>>> contents)
>>>>>
>>>>> What version control system?
>>>>>
>>>>> -David
>>>>>
>>>>> On Fri, Sep 12, 2014 at 11:25 AM, <ch.je...@gmail.com> wrote:
>>>>>
>>>>>> Hi,
>>>>>> Using reviewboard 2.0.6 and RBTools 0.6.2.
>>>>>> post-review worked fine and generated a new request.
>>>>>> When I looked into view diff for the request, it is failing.
>>>>>>
>>>>>> details error:
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>>>  line 236, in get
>>>>>>     renderer = self.create_renderer(context, *args, **kwargs)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py",
>>>>>>  line 1088, in create_renderer
>>>>>>     *args, **kwargs)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>>>  line 328, in create_renderer
>>>>>>     self.diff_file = self._get_requested_diff_file()
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>>>  line 369, in _get_requested_diff_file
>>>>>>     request=self.request)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>>>  line 373, in populate_diff_chunks
>>>>>>     chunks = generator.get_chunks()
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>>>  line 153, in get_chunks
>>>>>>     large_data=True)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py",
>>>>>>  line 109, in cache_memoize
>>>>>>     data = lookup_callable()
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>>>  line 152, in <lambda>
>>>>>>     lambda: list(self._get_chunks_uncached()),
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>>>  line 160, in _get_chunks_uncached
>>>>>>     new = get_patched_file(old, self.filediff, self.request)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>>>  line 201, in get_patched_file
>>>>>>     return patch(diff, buffer, filediff.dest_file, request)
>>>>>>   File 
>>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>>>  line 139, in patch
>>>>>>     'output': stderr,
>>>>>> Exception: The patch to 'test' didn't apply cleanly. The temporary files 
>>>>>> have been left in '/tmp/reviewboard.axR11W' for debugging purposes.
>>>>>> `patch` returned: 
>>>>>>
>>>>>>
>>>>>> ls /tmp/reviewboard.axR11W
>>>>>> tmppg8GFU  tmppg8GFU-new  tmppg8GFU-new.rej test.diff
>>>>>>
>>>>>> diff is generated properly in the files. tmppg8GFU-new.rej file and 
>>>>>> test.diff has proper differences.
>>>>>>
>>>>>> Pls. help.
>>>>>>
>>>>>> Thanks,
>>>>>> Jes 
>>>>>>
>>>>>>  -- 
>>>>>> Get the Review Board Power Pack at http://www.reviewboard.org/pow
>>>>>> erpack/
>>>>>> ---
>>>>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>>>>> ---
>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>>>>> --- 
>>>>>> You received this message because you are subscribed to the Google 
>>>>>> Groups "reviewboard" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it, 
>>>>>> send an email to reviewboard...@googlegroups.com.
>>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>>
>>>>>
>>>>>  -- 
>>>> Get the Review Board Power Pack at http://www.reviewboard.org/
>>>> powerpack/
>>>> ---
>>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>>>> ---
>>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to reviewboard...@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>
>>>  -- 
>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
>> ---
>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
>> ---
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to