What am I doing wrong? I made some changes, including "git mv"ing a
file and making some small changes to it. When I try to submit it for
review here is what I see:
# my reviewboard server reports version "2.0.10"
*$ rbt -v*
RBTools 0.6.2
*$ git --version*
git version 1.9.3 (Apple Git-50)
*$ rbt post*
ERROR: Error uploading diff
One or more fields had errors (HTTP 400, API Error 105)
path: *The revision '' for
'foo/bar/baz/DisjunctiveNormalFormTestCase.java' isn't in a valid format:
The SHA1 is too short. Make sure the diff is generated with `git diff
--full-index`.*
Your review request still exists, but the diff is not attached.
https://reviewboard.foo.bar.com/r/727043/
>From "-d" I suppose that the problem starts from this command:
* $ git diff --no-color --full-index --ignore-submodules
8f060e338c4f8f007e63810f0efef438dbd8cf4a..a43f07a5b0478263a2461bb1ceb1b788a4332793
-M*
Here is the snippet of this output for the offending file:
diff --git
a/foobarbaz/components/analytics/lib/test/com/foo/bar/analytics/DisjunctiveNormalFormTestCase.java
b/foobarbaz/components/analytics/lib/test/com/foo/bar/xyz0/DisjunctiveNormalFormTestCase.java
old mode 100755
new mode 100644
similarity index 99%
rename from
foobarbaz/components/analytics/lib/test/com/foo/bar/analytics/DisjunctiveNormalFormTestCase.java
rename to
foobarbaz/components/analytics/lib/test/com/foo/bar/xyz0/DisjunctiveNormalFormTestCase.java
index
72f141519d82a89ce0dc91c05d8a055d05998aa5..b99dcfdb29122b896b58b8c20490364d0b7b3269
---
a/foobarbaz/components/analytics/lib/test/com/foo/bar/analytics/DisjunctiveNormalFormTestCase.java
+++
b/foobarbaz/components/analytics/lib/test/com/foo/bar/xyz0/DisjunctiveNormalFormTestCase.java
@@ -1,4 +1,4 @@
-package com.foo.bar.analytics;
+package com.foo.bar.xyz0;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
@@ -11,8 +11,6 @@ import java.util.Set;
import org.junit.Test;
-import com.foo.bar.xyz0.DisjunctiveNormalForm;
-import com.foo.bar.xyz0.XYZQuery;
import com.foo.bar.xyz0.DisjunctiveNormalForm.Item;
import
com.foo.bar.xyz0.DisjunctiveNormalForm.MessageItemExprNormalForm;
import com.foo.bar.xyz0.parser.XYZParser;
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
