Hi Markus,

While our diff parser should be handling the property changes, it's
possible there's a bug there.

Can you file a bug on
https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and
attach a copy of that diff, so we can track this and inspect the raw
contents of the diff?

Thanks,

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Wed, Mar 2, 2016 at 1:34 AM, Markus Fischbacher <
markus.fischbac...@live.at> wrote:

> Hi Christian,
>
> thank you for your fast response.
>
> This is the log from Review Board:
>
> 2016-03-02 09:28:11,966 - DEBUG - None - AnonymousUser - /api/ -
> Attempting authentication on API: username=sst, password=************
> 2016-03-02 09:28:11,972 - DEBUG -  - Attempting to authenticate as CN=sst
> sst,OU=Systemaccounts,OU=euro,DC=euro,DC=com
> 2016-03-02 09:28:13,733 - DEBUG -  - DiffParser.parse: Beginning parse of
> diff, size = 925
> 2016-03-02 09:28:13,733 - ERROR -  - Unexpected error when validating diff.
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/webapi/resources/validate_diff.py",
> line 156, in create
>     save=False)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 417, in create_from_upload
>     save=save)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 441, in create_from_data
>     check_existence=(not parent_diff_file_contents)))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/managers.py",
> line 557, in _process_files
>     for f in parser.parse():
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 59, in parse
>     next_linenum, new_file = self.parse_change_header(i)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 100, in parse_change_header
>     linenum = self.parse_special_header(linenum, info)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/__init__.py",
> line 526, in parse_special_header
>     linenum, info)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/diffviewer/parser.py",
> line 162, in parse_special_header
>     info['index'] = self.lines[linenum].split(None, 1)[1]
> IndexError: list index out of range
> 2016-03-02 09:28:14,081 - DEBUG -  - Calculated issue counts for review
> request ID 744 across 1 review(s): Resulting counts = {u'R': 0, u'D': 0,
> u'O': 0}; DB values = [{u'screenshot_comments__issue_status': None,
> u'file_attachment_comments__pk': None,
> u'screenshot_comments__issue_opened': None, u'comments__pk': None,
> u'comments__issue_opened': None, u'file_attachment_comments__issue_opened':
> None, u'screenshot_comments__pk': None, u'comments__issue_status': None,
> u'file_attachment_comments__issue_status': None}]; Field IDs =
> {u'screenshot_comments': set([]), u'comments': set([]),
> u'file_attachment_comments': set([])}
>
> That's the diff:
>
> D:\DEV\test-repo>rbt diff
> Index: /trunk/ordner1/text1.txt
> ===================================================================
> --- /trunk/ordner1/text1.txt    (revision 30)
> +++ /trunk/ordner1/text1.txt    (working copy)
> @@ -3,4 +3,5 @@
>  test
>
>  test
> -bla bla
> \ No newline at end of file
> +bla bla
> +test
> \ No newline at end of file
> Index: /trunk
> ===================================================================
> --- /trunk      (revision 1)
> +++ /trunk      (working copy)
>
> Property changes on: trunk
> ___________________________________________________________________
> Added: reviewboard:url
> ## -0,0 +1 ##
> +http://review.efu.com
> \ No newline at end of property
> Index:
> ===================================================================
> ---     (revision 0)
> +++     (working copy)
>
> Property changes on: .
> ___________________________________________________________________
> Added: reviewboard:url
> ## -0,0 +1 ##
> +http://review.efu.com
> \ No newline at end of property
>
>
> Kind regards,
> Markus
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to