These diffs are for git (although our rb implementation has both git and
svn reviews) I'm not sure why they are being routed through svn. I'll say
it's a copy of our production 2.0.18 DB which has been upgraded to 2.5.3.

Jim

On Thursday, March 24, 2016, Christian Hammond <christ...@beanbaginc.com>
wrote:

> Hi Jim,
>
> It looks like you're posting a Git diff to a Subversion repository. I
> don't know how it got as far as it did (it should have failed validation),
> but Subversion revisions are integers, not hashes.
>
> Can you confirm what type of repository this is supposed to be?
>
> Christian
>
>
> On Thursday, March 24, 2016, Jim H <jim.locat...@gmail.com
> <javascript:_e(%7B%7D,'cvml','jim.locat...@gmail.com');>> wrote:
>
>> These were working in 2.0.18
>>
>> On Thursday, March 24, 2016 at 5:01:59 PM UTC-4, Jim H wrote:
>>>
>>> RB Version: 2.5.3
>>> Seems like the code is trying to convert a hash code to an int
>>> When clicking on a review for certain reviews I get this error
>>>
>>> *.*
>>> *.*
>>> *.*
>>>
>>> *  File
>>> "/wayfair/pkg/python2.7/latest/lib/python2.7/site-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/models.py",
>>> line 546, in _get_file_uncached*
>>> *    base_commit_id=base_commit_id)*
>>> *  File
>>> "/wayfair/pkg/python2.7/latest/lib/python2.7/site-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/__init__.py",
>>> line 147, in get_file*
>>> *    return self.client.get_file(path, revision)*
>>> *  File
>>> "/wayfair/pkg/python2.7/latest/lib/python2.7/site-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>>> line 100, in get_file*
>>> *    return self._do_on_path(self._get_file_data, path, revision)*
>>> *  File
>>> "/wayfair/pkg/python2.7/latest/lib/python2.7/site-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>>> line 69, in _do_on_path*
>>> *    normrev = self._normalize_revision(revision)*
>>> *  File
>>> "/wayfair/pkg/python2.7/latest/lib/python2.7/site-packages/ReviewBoard-2.5.3-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",
>>> line 117, in _normalize_revision*
>>> *    r = Revision(opt_revision_kind.number, six.text_type(revision))*
>>> *ValueError: invalid literal for int() with base 10:
>>> '40c014dabb4e265a7d150502a3e3a4c6a9eb4bac'*
>>>
>>>
>>> This is what I see in the UI
>>>
>>>
>>> <https://lh3.googleusercontent.com/-AHYw72zBqGI/VvRULsvivZI/AAAAAAAAADk/kdla7s5vA2wAcZruPEDtJ5AVV0SU_qUqQ/s1600/error_displaying_diff.JPG>
>>>
>>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> --
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com
> <javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');>
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to