Hi Terry,

Thanks for the report! We have a fix for this in our tree, but haven't
released it yet. It'll be part of 2.5.7, which we'll try to get out in the
next two weeks.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Fri, Aug 5, 2016 at 2:59 PM, Dunnigan, Terrence J <
terrence.j.dunni...@boeing.com> wrote:

> Hi,
>
>
>
> I’ve encountered a similar on 2.5.6.1 – a bad webhook causes a variety of
> errors including an error 500 message displayed to the user.
>
>
>
> - Exception thrown for user <username> at https://<server>/reviews/api/
> review-requests/7489/draft/
>
>
>
> HTTP Error 403: Forbidden
>
> Traceback (most recent call last):
>
>   File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py",
> line 112, in get_response
>
>     response = wrapped_callback(request, *callback_args, **callback_kwargs)
>
>   File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py",
> line 52, in _wrapped_view_func
>
>     response = view_func(request, *args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/django/views/decorators/vary.py",
> line 19, in inner_func
>
>     response = func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/resources/base.py",
> line 196, in __call__
>
>     request, method, view, api_format=api_format, *args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/
> resources/mixins/api_tokens.py", line 65, in call_method_view
>
>     return view(request, *args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/resources/base.py",
> line 464, in put
>
>     return self.update(request, *args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 122, in _call
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/reviewboard/webapi/decorators.py",
> line 139, in _check
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 122, in _call
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 143, in _checklogin
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 122, in _call
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 122, in _call
>
>     return view_func(*args, **kwargs)
>
>   File "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py",
> line 307, in _validate
>
>     return view_func(*args, **new_kwargs)
>
>   File "/usr/lib/python2.7/site-packages/reviewboard/webapi/
> resources/review_request_draft.py", line 493, in update
>
>     review_request.publish(user=request.user, trivial=trivial)
>
>   File 
> "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/review_request.py",
> line 848, in publish
>
>     changedesc=changes)
>
>   File "/usr/lib/python2.7/site-packages/django/dispatch/dispatcher.py",
> line 185, in send
>
>     response = receiver(signal=self, sender=sender, **named)
>
>   File 
> "/usr/lib/python2.7/site-packages/reviewboard/notifications/webhooks.py",
> line 240, in review_request_published_cb
>
>     dispatch_webhook_event(request, webhook_targets, event, payload)
>
>   File 
> "/usr/lib/python2.7/site-packages/reviewboard/notifications/webhooks.py",
> line 142, in dispatch_webhook_event
>
>     urlopen(Request(webhook_target.url, body, headers))
>
>   File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen
>
>     return opener.open(url, data, timeout)
>
>   File "/usr/lib64/python2.7/urllib2.py", line 437, in open
>
>     response = meth(req, response)
>
>   File "/usr/lib64/python2.7/urllib2.py", line 550, in http_response
>
>     'http', request, response, code, msg, hdrs)
>
>   File "/usr/lib64/python2.7/urllib2.py", line 475, in error
>
>     return self._call_chain(*args)
>
>   File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain
>
>     result = func(*args)
>
>   File "/usr/lib64/python2.7/urllib2.py", line 558, in http_error_default
>
>     raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
>
> HTTPError: HTTP Error 403: Forbidden
>
>
>
> Terry
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com]
> *On Behalf Of *David Trowbridge
> *Sent:* Sunday, March 20, 2016 7:39 PM
> *To:* reviewboard <reviewboard@googlegroups.com>
> *Subject:* Re: error 500 when closing a review
>
>
>
> https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard
>
>
>
> -David
>
>
>
> On Sun, Mar 20, 2016 at 6:09 AM eran meiri <eme...@gmail.com> wrote:
>
> where can I fill a bug?
>
>
>
> On Monday, 14 March 2016 19:32:53 UTC+2, David Trowbridge wrote:
>
> It looks like it's trying to notify a webhook handler that isn't
> responding.
>
>
>
> We probably should modify the webhook code to cope with failures more
> gracefully. Would you mind filing a bug?
>
>
>
> -David
>
>
>
> On Sat, Mar 12, 2016 at 11:24 PM eran meiri <eme...@gmail.com> wrote:
>
> Hello,
>
> I have a repeating problem that happens approximately once a week.
>
>
>
> when I try to close a review I get an error 500 internal server error and
> the as the system admin I get a mail:
>
>
>
>
>
> Traceback (most recent call last):
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/django/core/handlers/base.py", line 112, in
> get_response
>
>     response = wrapped_callback(request, *callback_args, **callback_kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/django/views/decorators/cache.py", line 52, in
> _wrapped_view_func
>
>     response = view_func(request, *args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/django/views/decorators/vary.py", line 19, in
> inner_func
>
>     response = func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/resources/base.py", line 195, in
> __call__
>
>     request, method, view, api_format=api_format, *args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/resources/mixins/api_tokens.py",
> line 65, in call_method_view
>
>     return view(request, *args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/resources/base.py", line 463, in
> put
>
>     return self.update(request, *args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 120, in _call
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/
> reviewboard/webapi/decorators.py", line 125, in _check
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 120, in _call
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 141, in
> _checklogin
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 120, in _call
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 120, in _call
>
>     return view_func(*args, **kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/djblets/webapi/decorators.py", line 301, in
> _validate
>
>     return view_func(*args, **new_kwargs)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/
> reviewboard/webapi/resources/review_request.py", line 841, in update
>
>     rich_text=close_description_rich_text)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/
> reviewboard/reviews/models/review_request.py", line 739, in close
>
>     type=type)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/
> python2.7/site-packages/django/dispatch/dispatcher.py", line 185, in send
>
>     response = receiver(signal=self, sender=sender, **named)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/
> reviewboard/notifications/webhooks.py", line 196, in
> review_request_closed_cb
>
>     dispatch_webhook_event(request, webhook_targets, event, payload)
>
>
>
>   File "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/
> reviewboard/notifications/webhooks.py", line 142, in
> dispatch_webhook_event
>
>     urlopen(Request(webhook_target.url, body, headers))
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 154, in urlopen
>
>     return opener.open(url, data, timeout)
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 431, in open
>
>     response = self._open(req, data)
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 449, in _open
>
>     '_open', req)
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 409, in _call_chain
>
>     result = func(*args)
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 1227, in http_open
>
>     return self.do_open(httplib.HTTPConnection, req)
>
>
>
>   File "/opt/reviewboard-2.5-0/python/lib/python2.7/urllib2.py", line
> 1197, in do_open
>
>     raise URLError(err)
>
>
>
> URLError: <urlopen error [Errno 111] Connection refused>
>
>
>
>
>
> <WSGIRequest
>
> path:/reviewboard/api/review-requests/438/,
>
> GET:<QueryDict: {}>,
>
> POST:<QueryDict: {u'status': [u'submitted'], u'api_format': [u'json']}>,
>
> COOKIES:{'50200000_clogin': 'l=1450772975&v=1&e=1450774778649',
>
>  'CoreID6': '46115918004114260672140&ci=50200000|ESTKCS',
>
>  'CoreM_State': '90~-1~-1~-1~-1~3~3~5~3~3~7~7~
> |~~|~~|~~|~||||||~|~~|~~|~~|~~|~~|~~|~~|~',
>
>  'CoreM_State_Content': '6~|~B1417B1ED807DAC4~4DA6F7D646B2100A~
> 60A0ADF25298D863~930589EE360D39AB~FF1C4C8A1D4F9BEC~
> 7ABC58E1025C795C~|~0~1~2~3~4~5',
>
>  '_ga': 'GA1.2.237002653.1431951981',
>
>  '_mkto_trk': 'id:685-NGF-137&token:_mch-redbend.com-1456394352819-60141',
>
>  'collapsediffs': 'True',
>
>  'csrftoken': '6xqphC46vlQ3mjtVrg3nXH2Vwicjz1W2',
>
>  'rbsessionid': '76ki5nln91jrlzhlukk2t2qbomkxli6v',
>
>  'utag_main': 'v_id:01501831e3f6001ab658f382414906
> 06c007206400bd0$_sn:4$_ss:0$_st:1450774778377$_pn:3%3Bexp-
> session$ses_id:1450772975338%3Bexp-session$dc_visit:1$dc_
> event:3%3Bexp-session$dc_region:eu-west-1%3Bexp-session'},
>
> META:{'CONTENT_LENGTH': '32',
>
>  'CONTENT_TYPE': 'application/x-www-form-urlencoded',
>
>  'CONTEXT_DOCUMENT_ROOT': '/opt/reviewboard-2.5-0/apache2/htdocs',
>
>  'CONTEXT_PREFIX': '',
>
>  'DOCUMENT_ROOT': '/opt/reviewboard-2.5-0/apache2/htdocs',
>
>  'GATEWAY_INTERFACE': 'CGI/1.1',
>
>  'HTTP_ACCEPT': 'application/json, text/javascript, */*; q=0.01',
>
>  'HTTP_ACCEPT_ENCODING': 'gzip, deflate, sdch',
>
>  'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8,he;q=0.6',
>
>  'HTTP_CONNECTION': 'keep-alive',
>
>  'HTTP_COOKIE': 'rbsessionid=76ki5nln91jrlzhlukk2t2qbomkxli6v; CoreID6=
> 46115918004114260672140&ci=50200000|ESTKCS; utag_main=v_id:
> 01501831e3f6001ab658f38241490606c007206400bd0$_sn:4$_ss:0$_
> st:1450774778377$_pn:3%3Bexp-session$ses_id:1450772975338%
> 3Bexp-session$dc_visit:1$dc_event:3%3Bexp-session$dc_
> region:eu-west-1%3Bexp-session; 
> 50200000_clogin=l=1450772975&v=1&e=1450774778649;
> CoreM_State=90~-1~-1~-1~-1~3~3~5~3~3~7~7~|~~|~~|~~|~||||||~|~~|~~|~~|~~|~~|~~|~~|~;
> CoreM_State_Content=6~|~B1417B1ED807DAC4~4DA6F7D646B2100A~
> 60A0ADF25298D863~930589EE360D39AB~FF1C4C8A1D4F9BEC~
> 7ABC58E1025C795C~|~0~1~2~3~4~5; collapsediffs=True; 
> _ga=GA1.2.237002653.1431951981;
> _mkto_trk=id:685-NGF-137&token:_mch-redbend.com-1456394352819-60141;
> csrftoken=6xqphC46vlQ3mjtVrg3nXH2Vwicjz1W2',
>
>  'HTTP_HOST': 'ilreviewb.redbend.com:8080',
>
>  'HTTP_ORIGIN': 'http://ilreviewb.redbend.com:8080',
>
>  'HTTP_REFERER': 'http://ilreviewb.redbend.com:8080/reviewboard/r/438/',
>
>  'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; WOW64)
> AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36',
>
>  'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
>
>  'LD_LIBRARY_PATH': '/opt/reviewboard-2.5-0/sqlite/lib:/opt/reviewboard-2.
> 5-0/python/lib:/opt/reviewboard-2.5-0/apache2/lib:
> /opt/reviewboard-2.5-0/common/lib:/opt/reviewboard-2.5-0/
> sqlite/lib:/opt/reviewboard-2.5-0/python/lib:/opt/
> reviewboard-2.5-0/apache2/lib:/opt/reviewboard-2.5-0/common/
> lib:/opt/reviewboard-2.5-0/git/lib:/opt/reviewboard-2.5-
> 0/apps/django/lib/python2.7/site-packages:/opt/
> reviewboard-2.5-0/memcached/lib:/opt/reviewboard-2.5-0/
> python/lib:/opt/reviewboard-2.5-0/mysql/lib:/opt/
> reviewboard-2.5-0/subversion/lib:/opt/reviewboard-2.5-0/
> sqlite/lib:/opt/reviewboard-2.5-0/apache2/lib:/opt/
> reviewboard-2.5-0/common/lib:',
>
>  u'LOCAL_SITE': None,
>
>  'PATH_INFO': u'/reviewboard/api/review-requests/438/',
>
>  'PATH_TRANSLATED': '/opt/reviewboard-2.5-0/apps/
> reviewboard/htdocs/rb-sites/reviewboard/htdocs/
> reviewboard.wsgi/reviewboard/api/review-requests/438/',
>
>  'QUERY_STRING': '',
>
>  'REMOTE_ADDR': '10.82.70.54',
>
>  'REMOTE_PORT': '62723',
>
>  'REQUEST_METHOD': 'PUT',
>
>  'REQUEST_SCHEME': 'http',
>
>  'REQUEST_URI': '/reviewboard/api/review-requests/438/',
>
>  'SCRIPT_FILENAME': '/opt/reviewboard-2.5-0/apps/
> reviewboard/htdocs/rb-sites/reviewboard/htdocs/reviewboard.wsgi',
>
>  'SCRIPT_NAME': u'',
>
>  'SERVER_ADDR': '10.82.73.138',
>
>  'SERVER_ADMIN': 'y...@example.com',
>
>  'SERVER_NAME':
>
>  'SERVER_PORT': '8080',
>
>  'SERVER_PROTOCOL': 'HTTP/1.1',
>
>  'SERVER_SIGNATURE': '',
>
>  'SERVER_SOFTWARE': 'Apache',
>
>  u'USERNAME': u'admin',
>
>  u'USER_EMAIL':
>
>  'mod_wsgi.application_group': 'localhost:8080|',
>
>  'mod_wsgi.callable_object': 'application',
>
>  'mod_wsgi.enable_sendfile': '0',
>
>  'mod_wsgi.handler_script': '',
>
>  'mod_wsgi.input_chunked': '0',
>
>  'mod_wsgi.listener_host': '',
>
>  'mod_wsgi.listener_port': '8080',
>
>  'mod_wsgi.process_group': 'wsgi-reviewboard',
>
>  'mod_wsgi.queue_start': '1457853609035814',
>
>  'mod_wsgi.request_handler': 'wsgi-script',
>
>  'mod_wsgi.script_reloading': '1',
>
>  'mod_wsgi.version': (3, 5),
>
>  'wsgi.errors': <mod_wsgi.Log object at 0x7ffc1e9d0d30>,
>
>  'wsgi.file_wrapper': <built-in method file_wrapper of mod_wsgi.Adapter
> object at 0x7ffc1ebf66c0>,
>
>  'wsgi.input': <mod_wsgi.Input object at 0x7ffc1e098630>,
>
>  'wsgi.multiprocess': True,
>
>  'wsgi.multithread': True,
>
>  'wsgi.run_once': False,
>
>  'wsgi.url_scheme': 'http',
>
>  'wsgi.version': (1, 0)}>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard...@googlegroups.com.
>
>
> For more options, visit https://groups.google.com/d/optout.
>
> --
>
> -David
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
> --
>
> -David
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to