Hi David, Please see - https://groups.google.com/d/msg/reviewboard/Xt4lVN14OSU/u1NhUVHhDgAJ. Currently RBTools doesn't generate/upload diff for uncommitted changes in GIT repository and hence I have to generate the diff myself and upload using diff-filename feature.
Is there any issue/request logged requesting this feature - posting diff for changes in working copy or index? Should I log a feature request? Thanks, Abhi On Saturday, September 17, 2016 at 1:30:45 AM UTC+5:30, David Trowbridge wrote: > > We have no immediate plans to allow review requests to span multiple > repositories since that's a pretty fundamental change to the database > schema. > > This is really only a problem when creating your own diffs and using rbt > post with --diff-filename. If you let rbt post do the diff, it would verify > that the current repository matched the review request you were trying to > update. > > -David > > On Fri, Sep 16, 2016 at 4:31 AM Abhishek Choudhary <xab...@gmail.com > <javascript:>> wrote: > >> After putting some debug logging in ReviewBoard code I was able to figure >> out the issue: >> >> I was putting a diff from a different repository in the already created >> review request which wasn't clear from the Error from RBTools command - may >> be we can be more specific here. It was a clear mismatch -between >> repositories which was wrong. >> >> Is there any plan to support multiple repositories in same review request? >> >> Server logs: >> >> *[Fri Sep 16 11:09:24.545492 2016] [wsgi:error] [pid 19647] YYY -in >> validate_diff.py repository: <Repository: guas-git> * >> >> [Fri Sep 16 11:09:24.545536 2016] [wsgi:error] [pid 19647] path: >> <InMemoryUploadedFile: diff (application/octet-stream)> >> >> [Fri Sep 16 11:09:24.545554 2016] [wsgi:error] [pid 19647] >> base_commit_id: None >> >> [Fri Sep 16 07:09:24.953046 2016] [wsgi:info] [pid 10408] mod_wsgi >> (pid=10408): Python home /u/choudhab/reviewboard/RBenv-2.5. >> >> [Fri Sep 16 07:09:24.953376 2016] [wsgi:info] [pid 10408] mod_wsgi >> (pid=10408): Initializing Python. >> >> [Fri Sep 16 07:09:25.126321 2016] [wsgi:info] [pid 10408] mod_wsgi >> (pid=10408): Attach interpreter ''. >> >> [Fri Sep 16 07:09:25.126557 2016] [wsgi:info] [pid 10408] mod_wsgi >> (pid=10408): Adding >> '/u/choudhab/reviewboard/RBenv-2.5/lib/python2.7/site-packages' to path >> >> . >> >> [Fri Sep 16 07:09:25.164827 2016] [wsgi:info] [pid 10408] mod_wsgi >> (pid=10408): Imported 'mod_wsgi'. >> >> [Fri Sep 16 11:09:25.367645 2016] [wsgi:error] [pid 19647] XXX- in >> diff.py the request for which diff is created: 19569L >> >> *[Fri Sep 16 11:09:25.367709 2016] [wsgi:error] [pid 19647] XXX- in >> diff.py the review request repository is: <Repository: aip>* >> >> [Fri Sep 16 11:09:25.367778 2016] [wsgi:error] [pid 19647] YYY- Form data: >> >> [Fri Sep 16 11:09:25.367796 2016] [wsgi:error] [pid 19647] PPP - >> '_encoding' : 'utf-8' >> >> [Fri Sep 16 11:09:25.367803 2016] [wsgi:error] [pid 19647] PPP - >> '_mutable' : True >> >> [Fri Sep 16 11:09:25.405357 2016] [wsgi:error] [pid 19647] YYY - diff.py >> UploadDiffForm: <reviewboard.reviews.forms.UploadDiffForm object at >> 0x2ab3fab11090> >> >> [Fri Sep 16 11:09:25.405436 2016] [wsgi:error] [pid 19647] OOO - 'files' >> : <MultiValueDict: {u'path': [<InMemoryUploadedFile: diff >> (application/octet-stream)> >> >> ]}> >> >> [Fri Sep 16 11:09:25.405453 2016] [wsgi:error] [pid 19647] OOO - >> 'is_bound' : True >> >> [Fri Sep 16 11:09:25.405473 2016] [wsgi:error] [pid 19647] OOO - >> 'cleaned_data' : {'parent_diff_path': None, 'path': <InMemoryUploadedFile: >> diff (application/ >> >> octet-stream)>, 'base_commit_id': None} >> >> [Fri Sep 16 11:09:25.405487 2016] [wsgi:error] [pid 19647] OOO - >> 'error_class' : <class 'django.forms.util.ErrorList'> >> >> [Fri Sep 16 11:09:25.405494 2016] [wsgi:error] [pid 19647] OOO - >> 'empty_permitted' : False >> >> *[Fri Sep 16 11:09:25.405525 2016] [wsgi:error] [pid 19647] OOO - >> 'repository' : <Repository: aip>* >> >> [Fri Sep 16 11:09:25.405573 2016] [wsgi:error] [pid 19647] OOO - 'fields' >> : {'path': <django.forms.fields.FileField object at 0x2ab3fb0e7e90>, >> 'parent_diff_pa >> >> th': <django.forms.fields.FileField object at 0x2ab3fb0e7f10>, >> 'base_commit_id': <django.forms.fields.CharField object at 0x2ab3fb0e7c10>} >> >> [Fri Sep 16 11:09:25.405585 2016] [wsgi:error] [pid 19647] OOO - >> 'initial' : {} >> >> [Fri Sep 16 11:09:25.409148 2016] [wsgi:error] [pid 19647] OOO - >> 'request' : <WSGIRequest >> >> [Fri Sep 16 11:09:25.409155 2016] [wsgi:error] [pid 19647] >> path:/api/review-requests/19569/diffs/, >> >> [Fri Sep 16 11:09:25.409157 2016] [wsgi:error] [pid 19647] >> GET:<QueryDict: {}>, >> >> >> On Friday, September 16, 2016 at 2:02:03 PM UTC+5:30, Abhishek Choudhary >> wrote: >>> >>> Hi, >>> >>> I am able to post diff for new files in the same repository. I am also >>> able to post diffs without errors in another repository with similar >>> configuration. >>> I have checked that the files exist in the remote. >>> >>> Any help will be appreciated. >>> >>> Thanks, >>> Abhi >>> >>> On Friday, September 16, 2016 at 12:27:33 PM UTC+5:30, Abhishek >>> Choudhary wrote: >>>> >>>> 'git diff HEAD > /var/tmp/rb_temp_diff_q7okiA' >>>> >>>> >>>> >>>> On Friday, September 16, 2016 at 4:15:13 AM UTC+5:30, David Trowbridge >>>> wrote: >>>>> >>>>> How are you creating the diff file that you're trying to upload? >>>>> >>>>> -David >>>>> >>>>> On Thu, Sep 15, 2016 at 1:07 PM Abhishek Choudhary <xab...@gmail.com> >>>>> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> I am using RBTools v0.7.6 with ReviewBoard v2.5.6.1 but I am not able >>>>>> to create review request using post command. I get below error. However, >>>>>> I >>>>>> am able to create review request for the same repository and diff from >>>>>> UI. >>>>>> >>>>>> Any help with this error will be appreciated. >>>>>> >>>>>> *RBtools error:* >>>>>> Note that /u/choudhab/base//bin/share/post-review.py is the same rbt >>>>>> script with some authentication customization for client side. >>>>>> >>>>>> Command: >>>>>> /u/choudhab/base//bin/share/post-review.py post --server >>>>>> reviewboard-staging.deshaw.com --summary "Personal#10377" >>>>>> --description "test" --review-request-id 19569 --target-people choudhab >>>>>> --bugs-closed personal/10377 --debug --publish --diff-filename >>>>>> /var/tmp/rb_temp_diff_q7okiA >>>>>> >>>>>> Traceback (most recent call last): >>>>>> File "/u/choudhab/base//bin/share/post-review.py", line 169, in >>>>>> <module> >>>>>> sys.exit(main()) >>>>>> File >>>>>> "/u/choudhab/reviewboard/RBenv-2.5/lib/python2.7/site-packages/rbtools/commands/main.py", >>>>>> >>>>>> line 133, in main >>>>>> command.run_from_argv([RB_MAIN, command_name] + args) >>>>>> File >>>>>> "/u/choudhab/reviewboard/RBenv-2.5/lib/python2.7/site-packages/rbtools/commands/__init__.py", >>>>>> >>>>>> line 629, in run_from_argv >>>>>> exit_code = self.main(*args) or 0 >>>>>> File >>>>>> "/u/choudhab/reviewboard/RBenv-2.5/lib/python2.7/site-packages/rbtools/commands/post.py", >>>>>> >>>>>> line 808, in main >>>>>> base_dir=base_dir) >>>>>> File >>>>>> "/u/choudhab/reviewboard/RBenv-2.5/lib/python2.7/site-packages/rbtools/commands/post.py", >>>>>> >>>>>> line 469, in post_request >>>>>> raise CommandError(u'\n'.join(error_msg)) >>>>>> rbtools.commands.CommandError: Error uploading diff >>>>>> >>>>>> >>>>>> The file was not found in the repository. (HTTP 400, API Error 207) >>>>>> >>>>>> Your review request still exists, but the diff is not attached. >>>>>> >>>>>> http://reviewboard-staging.com/r/19569/ >>>>>> >>>>>> >>>>>> >>>>>> *Some Server logs:* >>>>>> *from RBTools case:* >>>>>> [Thu Sep 15 19:47:46.462772 2016] [wsgi:error] [pid 18175] XXX- the >>>>>> request for which diff is created: <ReviewRequest: Personal#10377> >>>>>> [Thu Sep 15 19:47:46.485741 2016] [wsgi:error] [pid 18175] XXX- files >>>>>> - <InMemoryUploadedFile: diff (application/octet-stream)> >>>>>> >>>>>> *from UI case:* >>>>>> [Thu Sep 15 20:00:09.512906 2016] [wsgi:error] [pid 18175] XXX- the >>>>>> request for which diff is created: <ReviewRequest: (no summary)> >>>>>> [Thu Sep 15 20:00:09.538130 2016] [wsgi:error] [pid 18175] XXX- files >>>>>> - <InMemoryUploadedFile: temp.diff ()> >>>>>> >>>>>> Thanks, >>>>>> Abhi >>>>>> >>>>>> -- >>>>>> Supercharge your Review Board with Power Pack: >>>>>> https://www.reviewboard.org/powerpack/ >>>>>> Want us to host Review Board for you? Check out RBCommons: >>>>>> https://rbcommons.com/ >>>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>>> --- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "reviewboard" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to reviewboard...@googlegroups.com. >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.