Thank you for your reply. I will go to work on a patch then. (Seems I was not notified about it).
By the way, how would you like also adding I have tried rbslack, but I wanted something that was more flexible (e.g. I wanted to only watch some repositories, and dispatch some repositories to separate slack channels, and I could not see how rbslack's limited configuration model could possibly fulfill these requirements). On Thursday, December 1, 2016 at 2:06:22 AM UTC+1, Christian Hammond wrote: > > Hi Jean, > > That's funny, I thought we were including review request information along > with reviews/replies. Looks like we don't, just a link to the API for > fetching that information. I think it's reasonable to include the review > request along with the review/reply and would be fine taking a patch (with > unit tests) that includes this, if it's okay with David. > > As for Slack support, you may want to look into rbslack ( > https://github.com/reviewboard/rb-extension-pack/tree/master/rbslack) if > using Review Board 2.5. For 3.0, Slack support will be provided > out-of-the-box (see > https://github.com/reviewboard/rbintegrations/tree/master/rbintegrations/slack > ). > > Christian > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > > On Tue, Nov 29, 2016 at 1:52 AM, Jean Hominal <[email protected] > <javascript:>> wrote: > >> I am working on integrating my reviewboard instance with Slack using the >> webhook interface. >> >> It works pretty well for review_request_* events, but I cannot make it >> work (purely with the template) for reply_published and review_published >> events. >> >> The reason for that is that, in order to write a meaningful notification, >> I need information that pertains to the current review_request, which is >> not available in the payload for reply_published and review_published >> events. >> >> I think the simplest way of solving that would be for the payload of the >> reply_published and review_published events to also contain the >> review_request JSON, under the review_request key. >> >> To other users: would that be useful to you? >> To the developers: would you be open, in principle, to adding >> review_request in the payload of these events? I would be happy to propose >> a patch. >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
