Hi,

Recently I upgraded reviewboard from 2.0.15 to 2.5.7.

After upgrade, diff upload for git repo is failng.

*ERROR ON UI:*
The patch to 'index.js' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
`patch` returned: 

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

*After debugging, I found following error in reviewboard error logs:*
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get
    response = renderer.render_to_response(request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
    return HttpResponse(self.render_to_string(request))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
    large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
    compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
    items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 292, in <lambda>
    lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in <lambda>
    lambda: self.render_to_string_uncached(request),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
    request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks
    chunks = list(generator.get_chunks())
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
    for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
    large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
    compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
    items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 292, in <lambda>
    lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in <lambda>
    lambda: list(self.get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file
    return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch
    'output': stderr,
Exception: The patch to 'index.js' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
`patch` returned: 

   
*Could this error be caused because of GIT version and REVIEBOARD version 
incompatibility, or could it be something else?*

*Note: This issue is only in case of git patch upload, patch of mercurial 
repo is uploaded correctly.*

Regards,
Pritesh

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to