Hi, I could give it a try and see how far I get. Any pointers are welcome.
// Erik On 2 March 2017 at 07:11, Christian Hammond <christ...@beanbaginc.com> wrote: > Hey Erik, > > Thanks for the contribution! I think we need to think through how symlinks > should be handled. It might be worth expanding upon this to specifically > store symlink information in the FileDiff and then represent that a certain > way in the diff viewer to make it clear it's a symlink (like a banner at > the top of the diff display to show the symlink information). The behavior > can be common across other source control systems. > > Would you be interested in working toward that? I can give you pointers on > how to go about it. I understand if not, in which case we'll get a task in > our tracker to add the support (probably for 3.0 for now). > > Christian > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > > On Tue, Feb 28, 2017 at 12:07 PM, Erik Johansson <e...@ejohansson.se> > wrote: > >> Posted a review request instead: https://reviews.reviewboard.org/r/8785/ >> >> Perhaps easier to review in Review Board :) >> >> // Erik >> >> On 13 February 2017 at 20:28, Erik Johansson <e...@ejohansson.se> wrote: >> >>> Hi, >>> >>> Perhaps something like the attached patch can be used? >>> >>> // Erik >>> >>> On 13 February 2017 at 10:38, Erik Johansson <e...@ejohansson.se> wrote: >>> >>>> Hi, >>>> >>>> If one posts a review containing a removed symlink you get "There was >>>> an error displaying this diff." when looking at the diff view. This is with >>>> reviewboard 2.5.8 and a git repository. >>>> >>>> The attached patch reproduces the problem in a unit test. Let me know >>>> if you need any more info. >>>> >>>> Also, it seems like the tags for the just released reviewboard versions >>>> aren't pushed to github. >>>> >>>> // Erik >>>> >>>> -- >>>> Erik Johansson >>>> Home Page: http://ejohansson.se/ >>>> PGP Key: http://ejohansson.se/erik.asc >>>> >>> >>> >>> >>> -- >>> Erik Johansson >>> Home Page: http://ejohansson.se/ >>> PGP Key: http://ejohansson.se/erik.asc >>> >> >> >> >> -- >> Erik Johansson >> Home Page: http://ejohansson.se/ >> PGP Key: http://ejohansson.se/erik.asc >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
