Yeah I don't know what's with the two package names. We've been using this one for a long time, which has worked without hiccups. We can try moving to uglify-js, but given the version bump, I want to do a lot of testing first. We're going to be shipping some new releases very soon, so I'd want to hold off until after those go out to try upgrading to uglify-js 2.8.
Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Wed, Mar 29, 2017 at 12:39 PM, Erik Johansson <[email protected]> wrote: > Isn't it telling that the instructions on https://www.npmjs.com/package/ > uglifyjs for how to install the NPM is "npm install uglify-js" (note the > dash). > > Also, looking at the package.json file for version 2.4.10, the name is > actually uglify-js (https://github.com/mishoo/UglifyJS2/blob/v2.4.10/ > package.json). > > As for our local changes, I'm trying to push (at least some of) them > upstream... (https://reviews.reviewboard.org/r/8585/, hint hint :) ) > > // Erik > > > On 29 March 2017 at 21:18, Christian Hammond <[email protected]> > wrote: > >> Okay. Well, this sounds like a packaging issue on the RPM side (we're >> using the dependencies we mean to use), but someone rope me in if this >> turns out to be something we have to address locally. >> >> As for making changes to JavaScript/CSS, it's best if you can make these >> changes using an extension so you don't add to your maintenance burden or >> when upgrading Review Board, as things will undoubtedly break you in 3.0. >> >> Christian >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> >> On Wed, Mar 29, 2017 at 11:38 AM, Erik Johansson <[email protected]> >> wrote: >> >>> After making some local changes to javascript/css files (I think - I'm >>> not actually the person doing this, I just wanted to report it upstream to >>> hopefully have it fixed going forward). >>> >>> // Erik >>> >>> On 29 March 2017 at 20:30, Christian Hammond <[email protected]> >>> wrote: >>> >>>> Out of curiosity, why are you running collectstatic? >>>> >>>> Christian >>>> >>>> >>>> On Wed, Mar 29, 2017 at 11:25 Erik Johansson <[email protected]> >>>> wrote: >>>> >>>>> I'm not so sure that the problem is with the way Fedora packages >>>>> uglifyjs. I think the problem is that RB uses >>>>> https://www.npmjs.com/package/uglifyjs which seems to be version >>>>> 2.4.10 of https://github.com/mishoo/UglifyJS2 while Fedora packages >>>>> the latest version of https://github.com/mishoo/UglifyJS2 which is >>>>> available from https://www.npmjs.com/package/uglify-js. >>>>> >>>>> Something like the attached (untested) patches could perhaps be >>>>> applied? >>>>> >>>>> // Erik >>>>> >>>>> On 29 March 2017 at 16:02, Stephen Gallagher < >>>>> [email protected]> wrote: >>>>> >>>>> Would you please file a bug at https://bugzilla.redhat.com >>>>> /enter_bug.cgi?product=Fedora%20EPEL against the "python-djblets" >>>>> package with the exact commands you are running? >>>>> >>>>> I suspect it's a minor glitch with the way that Fedora packages >>>>> uglifyjs vs. the upstream NPM. I can probably have a patch fairly quickly >>>>> once you tell me how to reproduce it. >>>>> >>>>> >>>>> On Wed, Mar 29, 2017 at 9:34 AM Erik Johansson <[email protected]> >>>>> wrote: >>>>> >>>>> The EPEL package. >>>>> >>>>> // Erik >>>>> >>>>> >>>>> On Mar 29, 2017 15:10, "Stephen Gallagher" <[email protected]> >>>>> wrote: >>>>> >>>>> Did you install ReviewBoard using pip or did you use the EPEL package >>>>> for ReviewBoard and Djblets? >>>>> >>>>> On Wed, Mar 29, 2017 at 8:12 AM Erik Johansson <[email protected]> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> We are having problems running the collectstatic manage command on our >>>>> CentOS installation (RB 2.5.9). The problem is that we have the uglify-js >>>>> RPM installed which installs to /usr/lib/node_modules/uglify-js while >>>>> reviewboard/settings.py configures the path to be os.path.join( >>>>> NODE_PATH, 'uglifyjs', 'bin', 'uglifyjs') (i.e. uglifyjs instead of >>>>> uglify-js). >>>>> >>>>> This seems to be caused by RB (actually djblets) having a dependency >>>>> on the uglifyjs NPM instead of uglify-js, even though both seems to use >>>>> the >>>>> same source, but the latter seems to be more active. Any reason for this? >>>>> >>>>> // Erik >>>>> >>>>> -- >>>>> Erik Johansson >>>>> Home Page: http://ejohansson.se/ >>>>> PGP Key: http://ejohansson.se/erik.asc >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Erik Johansson >>>>> Home Page: http://ejohansson.se/ >>>>> PGP Key: http://ejohansson.se/erik.asc >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>>> -- >>>> Christian Hammond >>>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>>> Makers of Review Board <https://www.reviewboard.org/> >>>> >>>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Erik Johansson >>> Home Page: http://ejohansson.se/ >>> PGP Key: http://ejohansson.se/erik.asc >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Erik Johansson > Home Page: http://ejohansson.se/ > PGP Key: http://ejohansson.se/erik.asc > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
