Hi Lukasz, We intentionally don't show line endings. For most repositories, most setups, line endings are not a stable concept. That is, the line ending you check into a repository is not necessarily the line ending you get when it comes back out. It often depends on the platform, the type of repository, the tool used to check out, and the configuration. Sometimes you're not even dealing with \n vs \r\n, but sometimes \r, and sometimes \r\r\n. It gets crazy. As these differences can easily result in failures to patch, we do a lot of work to normalize the line endings prior to patching/rendering the diff, meaning the original line endings are gone.
If you're working to fix up line endings in a repository, there's frankly not much that will be reviewable by users, as we're not talking about logic or code changes. It's best to take care of that outside the code review process. Git, by the way, may normalize line endings at clone/pull time as well. It depends, again, on configuration and platform. See https://help.github.com/articles/dealing-with-line-endings/ I'm not sure what you mean about different heights between revisions. Can you show me a screenshot? Also, what version of Review Board are you using? You probably know this, but 1.7 is very old at this point. It's no longer supported by us. 2.0 is currently the oldest supported version of Review Board, which will change when 3.0 comes out in a few months. 2.0 and higher have an extension mechanism that companies can use to customize behavior without making upgrades harder. I don't know what kind of customizations you have, but it might be worth moving those into an extension. That's something we can talk about if you can tell me what sort of customizations you have. Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Mon, Apr 3, 2017 at 3:27 AM, Lukasz <[email protected]> wrote: > Hello all RB developers and users, > We have some problems with Review Board diff viewer. > > First one is related with line-endings. > We add lots of files with text lines endings Unix-styled (LF) in first > revision and then convert them into CR-LF (Windows) without changing its > contents in second revision. > We get for example, four pages of "changed files" (This diff has been > split across 4 pages), but this list is shrinking while loading page, so > finally we get only content-changed files. > > Summarize - we can see only couple of correctly changed files and four > pages of empty diff files in which only line-endings have changed. > Is Review Board in version 1.7 able to display somehow differences in line > endings? > > Git is recognizing such change. > > Second problem - sometimes diff blocks are not displayed correctly (they > are on different heights between revisions), maybe was there any fix for it? > > Our RB instance is strongly customized, that's why we can't update to > latest version. > > Thanks for your help, > Best regards, > Lukasz > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
