Thanks Christian! Rick
2017/5/1 下午8:25，"Christian Hammond" <christ...@beanbaginc.com>寫道： Hi Rick, Thanks for reporting this, and for the detailed bug report. The problem is that the "---" line looks like a file marker, and it's getting lost during diff normalization (where we work around a bunch of issues in svn diffs). We'll need to keep some additional state to deal with this. Let me follow up on the bug report with some extra details. Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Mon, May 1, 2017 at 5:45 PM, Rick Liu <totoroliu...@gmail.com> wrote: > Hi, > > I just reported a bug under ReviewBoard bug system: > https://hellosplat.com/s/beanbag/tickets/4546/ > > But I'd like to know if there's a quick work-around for the issue. > > I have a test file example like below under SVN: > > > ``` > > -- test line1 > -- this line (test1) > -- test lin2 > -- test line (test2) > ``` > > And then I remove the LINE#2: > ``` > -- this line (test1) > ``` > > svn diff would show: > ``` > > $ svn diff > Index: test > =================================================================== > --- test (revision 16006) > +++ test (working copy) > @@ -1,4 +1,3 @@ > -- test line1 > --- this line (test1) > -- test lin2 > -- test line (test2) > > ``` > > But rbt diff is missing the line of change: > ``` > > $ rbt diff > Index: /TestProject/trunk/Test/folder/test > =================================================================== > --- /TestProject/trunk/Test/folder/test (revision 16006) > +++ /TestProject/trunk/Test/folder/test (working copy) > @@ -1,4 +1,3 @@ > -- test line1 > -- test lin2 > -- test line (test2) > > ``` > > > I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF > source line. > I'm currently using rbtools-0.7.9, > and wondering if there can be a quick patch/fix for this? > > > Thanks, > Rick > > > > > > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/ powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group. To unsubscribe from this topic, visit https://groups.google.com/d/ topic/reviewboard/POjfbwnXg-4/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
