Hi Christian, Thank you for your fast response. I joined my team when they already had existing Review Board v1.5.1 (quite old I suppose) running, which the used with two repositories. Perforce, and our custom one. I do not know any details, but we could not use v1.5.1 with perforce anymore because of some login issues and this was the reason for the upgrade, since in v2.5 there was already a fix for that.
Anyway there were some differences between the diff formats for example in 1.5.1: the files started with: Index:< path to the class> =================== +++ <our class> <path+ class> --- <our class> <timestamp> in 2.5.x --- <path1 + path2 + class> +++<path+class + timestamp> So it was not possible to display the old diff files, from v1.5.1, in the new Review Board site. Best regards, Kristiyan понеделник, 29 май 2017 г., 13:35:42 UTC+3, Christian Hammond написа: > > Hi Kristiyan, > > Thanks for the kind words :) > > Not to worry, this is an internal change with the diff parsing logic. If > your extension provided a custom DiffParser subclass designed to parse a > custom unified diff variant, then you'd be affected, but this change > doesn't impact any standard uses. The change to diff parsing just makes our > parsing more efficient and memory-friendly. The file format for diffs > haven't changed. > > So you're in good shape with questions #1 and #2. No changes required. > > I'm curious about #3. Which P4 security changes, and what issues were you > seeing with the diff syntax? Was this with Perforce or Review Board? What > versions of Review Board did this affect? I'm not really sure what you hit > or why, and would like to understand that better. > > Christian > > On Mon, May 29, 2017 at 3:19 AM, Kristiyan Gostev <kristiy...@gmail.com > <javascript:>> wrote: > >> Hello, >> >> I have the pleasure to administrate Review Board site in our organization >> and I follow with great interest every update. >> Since we have custom extensions on our site that support source code >> repository which is used only in our organization, one sentence raised some >> questions: "Rewrote diff parsing and storage for faster uploads." >> >> 1. Is it possible to submit diffs with older versions of the RBTools >> (0.7.5 for example)? >> 2. Is it backward compatible? I mean, Is it possible to review diffs >> posted in v2.5.6 if the site is updated? >> 3. Is there any differences in the diff syntax and you plan to rewrite >> the syntax again? We had to migrate from older version of the site to a new >> one, because of P4 security changes and the process was really slowed down, >> because the diff syntax was changed and the site could not show diff files >> posted with the other syntax (from our custom repository, not P4). But I >> assume that was necessary because of some changes in the "patch" tool for >> linux, isn`t it? >> >> We are really happy with the current release, but If we are forced to >> update or upgrade again, I prefer to prepare earlier. :) >> >> Best regards, >> Kristiyan Gostev >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
