Hi Chann,

It's actually trying to run 'rbt patch', and failing to find 'rbt'. It's
possible it explicitly wants 'rbt.exe'. This code path may need some
tweaking (in fact, it's bypassing our main "execute a program"
functionality, so it definitely needs some tweaking there).

We can look into it for the next release (my plate's too full to poke at it
this week), but that doesn't help you right now, so... how comfortable do
you feel with Python? I could guide you toward some things to try.

Christian

On Tue, Jul 11, 2017 at 1:51 PM, Chann An <[email protected]> wrote:

> I tried patch.exe from gnu and cygwin.  Both gave me me the same error.
> And "rbt patch"  works so I don't think it's an issue with patch.exe.
> Maybe something funky with ' errread, errwrite' for windows?
>
> On Tuesday, July 11, 2017 at 1:24:11 PM UTC-7, David Trowbridge wrote:
>>
>> It looks like you don't have gnu patch installed. rbt land is a
>> relatively new command and apparently we don't have good error handling for
>> this case yet.
>>
>> -David
>>
>> On Tue, Jul 11, 2017 at 10:58 AM Chann An <[email protected]> wrote:
>>
>>> I'm getting an error every time I do a 'rbt land -r <rb #>' on windows 7
>>> and windows 2012r2 in git bash.  Same command runs perfectly on mac.  The
>>> error says I'm missing the patch command but it's there in my path.  rbt
>>> patch works also with no problems.  It's just when i do a land with a
>>> revision number.  Any help would be greatly appreciated.
>>>
>>> rbt land -d -r 1037450
>>>
>>> >>> RBTools 0.7.10
>>>
>>> >>> Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC
>>> v.1500 32 bit (Intel)]
>>>
>>> >>> Running on Windows-2012ServerR2-6.3.9600
>>>
>>> >>> Home = C:\Users\can
>>>
>>> >>> Current directory = C:\repository\test
>>>
>>> >>> Command line: rbt land -d -r 1037450
>>>
>>> >>> Running: tf vc help
>>>
>>> >>> Checking for a Subversion repository...
>>>
>>> >>> Unable to execute "svn help": skipping SVN
>>>
>>> >>> Checking for a Git repository...
>>>
>>> >>> Running: git rev-parse --git-dir
>>>
>>> >>> Running: git config core.bare
>>>
>>> >>> Running: git rev-parse --show-toplevel
>>>
>>> >>> Running: git symbolic-ref -q HEAD
>>>
>>> >>> Running: git config --get branch.env_stage.merge
>>>
>>> >>> Running: git config --get branch.env_stage.remote
>>>
>>> >>> Running: git config --get remote.origin.url
>>>
>>> >>> repository info: Path: xxx, Base path: , Supports changesets: False
>>>
>>> >>> Making HTTP GET request to https://rb.corp.linkedin.com/api/
>>>
>>> >>> Running: git status --porcelain --untracked-files=no
>>> --ignore-submodules=dirty
>>>
>>> >>> Making HTTP GET request to https://xxx/api/review-requests/1037450/
>>>
>>> >>> Cached response for HTTP GET https://xxx/api/review-request
>>> s/1037450/ expired and was not modified
>>>
>>> Applying patch from review request 1037450
>>>
>>> Traceback (most recent call last):
>>>
>>>   File "C:/Program Files 
>>> (x86)/RBTools/bin/../Python27/Scripts/rbt-script.py",
>>> line 11, in <module>
>>>
>>>     load_entry_point('RBTools==0.7.10', 'console_scripts', 'rbt')()
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\sit
>>> e-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\main.py", line
>>> 133, in main
>>>
>>>     command.run_from_argv([RB_MAIN, command_name] + args)
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\sit
>>> e-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\__init__.py", line
>>> 663, in run_from_argv
>>>
>>>     exit_code = self.main(*args) or 0
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\sit
>>> e-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\land.py", line
>>> 261, in main
>>>
>>>     self.patch(request_id)
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\sit
>>> e-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\land.py", line
>>> 130, in patch
>>>
>>>     p = subprocess.Popen(patch_command)
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\subprocess.py",
>>> line 390, in __init__
>>>
>>>     errread, errwrite)
>>>
>>>   File "C:\Program Files (x86)\RBTools\Python27\lib\subprocess.py",
>>> line 640, in _execute_child
>>>
>>>     startupinfo)
>>>
>>> WindowsError: [Error 2] The system cannot find the file specified
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to