here is the patch in question attached,
the issue showed on ubuntu 12.04.5
Reviewboard 2.5.4 then 2.5.15
python 2.7.3
here is the complete log:
Traceback (most recent call last):
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/views.py",
line 300, in get
response = renderer.render_to_response(request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 74, in render_to_string
large_data=True)
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 298, in cache_memoize
compress_large_data))
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 252, in cache_memoize_iter
items = items_or_callable()
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 295, in <lambda>
lambda: [lookup_callable()],
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 73, in <lambda>
lambda: self.render_to_string_uncached(request),
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 87, in render_to_string_uncached
request=request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 669, in populate_diff_chunks
chunks = list(generator.get_chunks())
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 786, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 107, in get_chunks
large_data=True)
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 298, in cache_memoize
compress_large_data))
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 252, in cache_memoize_iter
items = items_or_callable()
File
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.9-py2.7.egg/djblets/cache/backend.py",
line 295, in <lambda>
lambda: [lookup_callable()],
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 106, in <lambda>
lambda: list(self.get_chunks_uncached()),
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 793, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 233, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
File
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.15-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 169, in patch
'output': stderr,
Exception: The patch to
'jhoang/Rel_22.0.1123_Bundle3_v4/WebApps/CommPilot/ServiceProvider/DefaultConfig/Nested/CustomTags/body.jsp'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.OMLo8e' for debugging purposes.
`patch` returned:
As mentionned it happend on both 2.5.4 and 2.5.15 as the diff is really
small I guess it might be some syntax that it does not like, I tried a
couple times, changed some blank space just in case, did not help.
first time seeing this error in over 13k reviews
--
http://www.broadsoftconnections.com
This email is intended solely for the person or entity to which it is
addressed and may contain confidential and/or privileged information. If
you are not the intended recipient and have received this email in error,
please notify BroadSoft, Inc. immediately by replying to this message, and
destroy all copies of this message, along with any attachment, prior to
reading, distributing or copying it.
Ce message confidentiel et les éventuelles pièces jointes sont à l’usage
exclusif de son ou de sa destinataire. Il est interdit, pour toute autre
personne, de le distribuer, d’en dévoiler le contenu ou de le reproduire.
Si vous avez reçu cette communication par erreur, veuillez en informer
immédiatement l’expéditeur par courrier électronique et détruire l’original
de ce message ainsi que toute copie.
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
Index: body.jsp
===================================================================
--- body.jsp (revision 669241)
+++ body.jsp (working copy)
@@ -70,7 +70,7 @@
formats = spDeviceTagTableFormatter.formatColumns(new ColumnFormat[]{cf1, cf2, cf3},FmtTable, FmtTable.getTableName());
} else {
- formats = spTagTableFormatter.formatColumns(new ColumnFormat[]{cf1, cf2},FmtTable, FmtTable.getTableName());
+ formats = spDeviceTagTableFormatter.formatColumns(new ColumnFormat[]{cf1, cf2}, FmtTable, FmtTable.getTableName());
}
