Yes, the "<revision>" part is the blob SHA, not the commit SHA. This has been the case since git support was initially added.
It is possible to support hosting services that require a commit SHA rather than a blob SHA, but it means writing a hosting service backend in Review Board and using RBTools to post all code changes for review (since diff files don't contain the commit SHA) -David On Tue, Oct 31, 2017 at 10:10 AM Garrett Dewald <garrett.dew...@deem.com> wrote: > I'm trying to configure our git service as a custom git repository in > Reviewboard, and I'm having trouble understanding the raw URL definition: > > A URL mask used to check out a particular revision of a file using HTTP. >> This is needed for repository types that can't access remote files >> natively. Use <revision> and <filename> in the URL in place of the >> revision and filename parts of the path. > > > The above seems to imply that the revision will be used in the raw URL, > but in practice the diff is verified using the object hash rather than the > revision (i.e. commit) hash, which my custom repository (gogs > <https://gogs.io/>) unfortunately does not support. We are using > reviewboard 2.5, is this the expected behavior and is it the same in other > versions of reviewboard? > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
