Thanks very much.
A little more question, I am trying to write a extension by starting with
'rbext create'
But it seems broken
(venv) root@5e17c3318a2a:/var/www/reviewboard# rbext create --name 'TestExt'
ERROR: Unable to import settings_local.py: No module named
settings_local
ERROR:root:Unexpected exception when running command "create": name
'DATABASES' is not defined
Traceback (most recent call last):
File
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/cmdline/rbext.py",
line 839, in run
return command.run(options)
File
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/cmdline/rbext.py",
line 70, in run
return self.main(options)
File
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/cmdline/rbext.py",
line 254, in main
self._process_options(options)
File
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/cmdline/rbext.py",
line 360, in _process_options
print(ugettext('Using "%s" as the package name.') % package_name)
File
"/opt/venv/local/lib/python2.7/site-packages/django/utils/translation/__init__.py",
line 76, in ugettext
return _trans.ugettext(message)
File
"/opt/venv/local/lib/python2.7/site-packages/django/utils/translation/__init__.py",
line 52, in __getattr__
if settings.USE_I18N:
File
"/opt/venv/local/lib/python2.7/site-packages/django/conf/__init__.py", line
54, in __getattr__
self._setup(name)
File
"/opt/venv/local/lib/python2.7/site-packages/django/conf/__init__.py", line
49, in _setup
self._wrapped = Settings(settings_module)
File
"/opt/venv/local/lib/python2.7/site-packages/django/conf/__init__.py", line
128, in __init__
mod = importlib.import_module(self.SETTINGS_MODULE)
File
"/opt/venv/local/lib/python2.7/site-packages/django/utils/importlib.py",
line 40, in import_module
__import__(name)
File
"/opt/venv/local/lib/python2.7/site-packages/reviewboard/settings.py", line
327, in <module>
for db_info in DATABASES.values():
NameError: name 'DATABASES' is not defined
(venv) root@5e17c3318a2a:/var/www/reviewboard# rb-site --version
rb-site 3.0.6
Python 2.7.15rc1 (default, Apr 15 2018, 21:51:34)
[GCC 7.3.0]
Installed to /opt/venv/local/lib/python2.7/site-packages/reviewboard
What can I do to let rbext work?
On Saturday, June 2, 2018 at 5:48:15 AM UTC+8, Christian Hammond wrote:
>
> Hi Kirby,
>
> There's no functionality for this. We work on a model where anybody on the
> server can be part of the review process.
>
> We have a concept of "approval" on the API level, which is what tools like
> "rbt land" and repository hooks use to determine whether a change can be
> landed. This defaults to ">= 1 Ship Its AND no open issues," but that logic
> can be customized using ReviewRequestApprovalHook in a custom extension.
> See
> https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/
>
> Christian
>
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
