We're aiming for a Review Bot 1.0.1 release on the 11th (this may slip based on other factors, but that's the current date scheduled).
As for there being a limit... There shouldn't be, but clearly something is going wrong. flake8 should be ignoring anything that isn't a Python file... Perhaps there's something in the output that we're failing to parse, leading to an internal error. Can you check the Review Bot log file (try /var/log/reviewbot/current) and see if there's any errors showing up from flake8? Christian On Tue, Jul 3, 2018 at 2:32 PM Joshua Cannon <joshdcan...@gmail.com> wrote: > I noticed that flake8 would "pass" if it internally errored. It has since > been fixed (but not yet released) > See https://hellosplat.com/s/beanbag/tickets/4710/ > > On Friday, June 8, 2018 at 11:46:57 AM UTC-5, Peter Simms wrote: >> >> Seems it happens when I add a lot of different files and languages. >> >> So if I add just some python files it will work, but if I add a lot of >> python, c++ and javascript, the cppchecks will fail with issues but flake8 >> and also jshint will pass even though it should fail. >> >> Is there a limit to the amount of files/languages that it will flag up >> issues? >> >> It appears to be inconsistent when working with lots of different file >> types. >> >> On Thursday, 7 June 2018 12:12:24 UTC+1, Peter Simms wrote: >>> >>> That was ticked, I am not sure how but it seems to have fixed itself, >>> thank you for getting back to me >>> >>> On Tuesday, 5 June 2018 07:44:30 UTC+1, David Trowbridge wrote: >>>> >>>> Hi, >>>> >>>> In the integration configuration, did you select "Comment on unmodified >>>> code"? If not, the errors will be filtered to include only those things >>>> which occur in lines that are actually changed in the diff, which might be >>>> nothing even if the file itself has a bunch of problems. >>>> >>>> -David >>>> >>>> On Mon, Jun 4, 2018 at 10:38 AM Peter Simms <petema...@gmail.com> >>>> wrote: >>>> >>>>> Hi all, >>>>> >>>>> I have recently setup a test reviewboard server. I am experimenting >>>>> with setting up reviewbot to run tests on posting a review. >>>>> >>>>> I am trying to get flake8 setup correctly, however it seems to always >>>>> pass, I know there are issues with the python files however it always >>>>> passes, I am not 100% on where to troubleshoot as the logs don't seem to >>>>> say anything. >>>>> >>>>> Can someone point me in the right direction as to why flake8 always >>>>> passes? >>>>> >>>>> Machine setup >>>>> Centos 7 >>>>> Review Board 3.0.6 >>>>> >>>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Review Board Community" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to reviewboard...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
