Hi, Im trying to build a custom extension following the example in https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/#review-request-approval-hook to check if a user needs to have X number of Ship-Its before its approved. I have installed the extension and run breakpoints through it, which go through the flow and return a tuple of False, <Error message>.
But the reviewboard UI doesnt reflect any of that and happily accepts the Ship-It even if its just the first one. Is this a bug? Is an frontend extension also needed to make this work? I was expecting the UI to throw an alert indicating that there needs to be X Ship-Its (The error message returned from the extension) Environment: Virtual env running Reviewboard from source: Branch 3.0.x Extension source is pretty much copied from the link above. Thanks Raja -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
