Hi, This is expected. They only take effect for the initial review request. The idea is to prevent overriding the list of targeted reviewers, or to re-add someone who was removed, based on a re-run of the algorithm. Consider for instance an important confidential security fix that may initially trigger a Default Reviewer rule adding some people or groups to the list, but the owner of the review request erases them all and assigns it instead to a private "security" group. You wouldn't want anyone re-added if you were to update your change, for security disclosure reasons. Instead, once the review request is published, those fields are meant to be your responsibility to update.
Christian On Thu, Oct 25, 2018 at 3:16 PM manoj m <manojm....@gmail.com> wrote: > Hello, > > If an user uploads a new diff to an already published review request the > default groups doesn't get updated. Is this expected? > > On the contrary, an unpublished review requests gets updated properly. > > Thanks > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
