We use the GitHub CDN to provide the images, for licensing and package size reasons. Only the browser needs access to the Internet. We haven't optimized this for environments where the browser is limited solely to the corporate network, but there are ways we can address that in future releases if important to customers.
The URLs generated for the CDN come from a Python library we use. That does not require any network connectivity. As for this particular issue, I have found the core problem, which is that the library we use generates URLs that no longer exist on GitHub. I suspect we'll just be able to bump the version. Planning to address this one way or another for the coming release. Christian On Wed, Apr 24, 2019 at 1:49 PM Dunnigan (US), Terrence J < [email protected]> wrote: > If I understand correctly, you’re saying that Review Board uses a service > to provide some emoticons. What happens if the service is unavailable, e.g. > running Review Board on an isolated network? > > > > Terry > > > > *From:* [email protected] [mailto:[email protected]] > *On Behalf Of *Christian Hammond > *Sent:* Thursday, April 18, 2019 10:43 PM > *To:* [email protected] > *Subject:* Re: ReviewBoard renders broken image along with emoticons > > > > Hi, > > > > That does seem quite wrong. We use a third-party library for the > processing and renders, and a service for the icons, so I’ll have to look > into whether it’s an issue there or on our end. > > > > Can you give me a few bits of info to help look into this further: > > > > 1) Which browser are you using? > > 2) What version of Review Board is this? > > 3) What’s the URL to the broken image? Can I also see the HTML for the > rendered content? Your browser’s developer tools can help with that. > > 4) To confirm, is the text editor set for Markdown mode? > > > > Christian > > > > > > On Thu, Apr 18, 2019 at 17:27 <[email protected]> wrote: > > > > Previously, I could type a short-code for an emoji like :ok:, :+1:, > :thumbsup:, :100:, etc. and they would correctly resolve to their > emoticon. > they do so now too, but the final rendered emoticon has a broken image as > shown: > > When typing :ok_hand:, result is > > [image: broken emoticon.png] > This looks weird and is an off-putter when expressing the intent from an > emoticon. > > > Om > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > > -- > > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
