Hi Deepanshu, Yes, it's expected. We don't do byte-for-byte diffing. We normalize all newlines. This is a very important step, because diffs are never guaranteed to use the same type of newline as the version in the repository. This is because a repository may keep one version of a file (often normalized itself, just like we're doing) and present a different version to clients based on their OS or settings.
Worse, if editing files on one system (say, Linux) that are checked out on another (Windows) via a network share or some other mechanism, diffs can end up with very confused line endings. We see this with Perforce a lot, where files (or at least parts of files) use \r\r\n for newlines, due to confusion between the editor and Perforce itself. Is there a particular case that's biting you here? Are you just interested in whether there's a change in the presence of a trailing newline in the file? Christian On Thu, Apr 11, 2019 at 7:56 AM Deepanshu Arora <[email protected]> wrote: > > Hi Christian, > > Review board is treating these two lines as same (present in different > files) and shows there is no difference between them. > > File 1 -> String name; > File 2 -> String name;\r > > Is this behavior expected? > > Thanks, > Deepanshu > > > On Wed, Apr 10, 2019 at 10:19 AM Christian Hammond < > [email protected]> wrote: > >> Hi, >> >> Sorry, I'm not sure which issue you're referring to. Can you go into more >> details on this? >> >> Christian >> >> On Tue, Apr 9, 2019 at 9:00 AM Deepanshu Arora <[email protected]> >> wrote: >> >>> Hi Christian, >>> >>> Is this still an issue in RB v3.0.8? Just to clarify, I am facing an >>> issue where reviewboard does not show \r in diff? Is that known behvaiour? >>> >>> Thanks, >>> Deepanshu >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Review Board Community" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "Review Board Community" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/BUwooo5dy4g/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
