Hi Gabriel, I *think* the UI feature you're discussing is the same as our diff revision slider. Every time you upload a new diff for review (after making changes based on review feedback or otherwise iterating on the change), we give it a new diff upload revision on that review request. The diff viewer lets you change both the starting diff revision (upstream or any uploaded diff) and the ending diff revision, showing the differences between those.
This is documented here: https://www.reviewboard.org/docs/manual/3.0/users/reviews/reviewing-diffs/#viewing-other-diff-revisions The same slider is used to change the diff range for file attachments as well. This works for all text-based files, rendered Markdown files, image files, and PDF files (when using Power Pack <https://www.reviewboard.org/powerpack/>). Is that what you're referring to? It looks like it from the screenshots and the linked documentation. Christian On Tue, May 28, 2019 at 4:18 PM Gabriel Morin <[email protected]> wrote: > Hi! > > I'm looking into using ReviewBoard with Perforce, and being used to > CodeCollab I find that your product holds up surprisingly well in some > aspects, in addition to having a slicker UI. > > One major useful feature in Collab however is the ability to change what > you are diffing against when viewing a file diff, namely any upload that > was done to update the review, or any committed revision of the file if it > was modified in source control since the start of the review. See > attachment for a screenshot where the file wasn't updated externally, so > only revision #3 shows. If I had to merge other people's changes, there > would be a Version #4, Version #5 and so on, which correspond to the > Perforce file revisions. > > Swarm added a similar functionality in recent versions: see first > screenshot here: > https://www.perforce.com/manuals/swarm/Content/Swarm/basics.diffs.html#Viewing_a_diff > - > it's becoming a pretty standard feature. (Direct link to screenshot: > https://www.perforce.com/manuals/swarm/Content/Resources/Images/swarm-panel-diffs.png > ) > > I was wondering if you're planning to add this to ReviewBoard, and whether > there are major technical obstacles to implementing that. Honestly if it > did have this feature it would become a credible CodeCollab replacement in > my view, with the added benefit of being open-source. > > Thanks, > Gabriel > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/7dee50f3-51c5-4fe6-8176-14b1e111773b%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/7dee50f3-51c5-4fe6-8176-14b1e111773b%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3DTMxSUCC6FT7K4668dy-dohxDmNOoKVqpQcmWW%3DGrM5Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
