So there's a challenge with this that I hadn't considered before. We don't automatically create an index for the branch field. While we could push an update that adds one, this can impact upgrades to 3.0.16, potentially taking a substantially long time to complete. We try to avoid this for point releases, so I'd feel a lot more comfortable adding this index in 4.0, where we're already performing modifications to the database schema.
We could still add the query argument in 3.0.16, but performance wouldn't be ideal without manually adding an index (which may then need to be manually removed when 4.0 is out). So unfortunately, not as clear-cut as I was hoping. Going to need to ponder this... Christian On Tue, Oct 22, 2019 at 11:14 PM Christian Hammond <[email protected]> wrote: > Hi Paul, > > Hmm, I thought we had this as part of the API. I'll add that for 3.0.16. > We're aiming for an early-November release, trying to wrap up some work > before we get that release ready, but it'll probably be the 5th or the 12th. > > If need-be, extensions can always provide custom API to fill in the gaps > that we're missing, if it's blocking you on something and you can't wait > until the next release. > > Christian > > On Mon, Oct 21, 2019 at 3:04 AM Paul Mansfield < > [email protected]> wrote: > >> Hi, >> imagine I have some reviews done on a feature branch called >> "SCRATCH-123", and I want to search for them using the API. >> >> is this possible? >> >> reading the documents at >> https://www.reviewboard.org/docs/manual/3.0/webapi/ and >> >> https://www.reviewboard.org/docs/manual/3.0/webapi/2.0/resources/review-request-list/ >> >> suggests there isn't that ability, it doesn't seem to be possible filter >> on the branch? then I would have to get a list of all review requests on a >> repository and then iterate and filter myself? >> >> thanks >> Paul >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/reviewboard/3b47b04e-3feb-4bec-9e84-ee749b00150d%40googlegroups.com >> <https://groups.google.com/d/msgid/reviewboard/3b47b04e-3feb-4bec-9e84-ee749b00150d%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7Vndn-N88haVT-wNwhc43hwerC4A1Dk4canSSOgToy0CmmJA%40mail.gmail.com.
