Hi Paul, The former is certainly worth considering (though when people are testing/evaluating, it's not uncommon for someone to review and Ship It their own changes).
The latter can be done by overriding approval logic using ReviewRequestApprovalHook in an extension, and by using `rbt land` (which provides some enforcement, but weaker as it's client-side) and/or a repository-side pre-commit hook that checks the approved flag for the review request referenced in commit messages (stronger enforcement). https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/ Christian On Thu, Jan 2, 2020 at 2:26 AM Paul Mansfield < [email protected]> wrote: > as a thought. is it possible with RB to disallow the person submitting the > review from being able to Ship-It? > also, is it possible to make RB block the landing a review without two > ship-it's from two different people? > > this would help enforce good practises, many orgs including ours require > two ship-its for merging to master. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/33cfd45e-93a0-4d35-b478-79eda0ceeb83%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/33cfd45e-93a0-4d35-b478-79eda0ceeb83%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3DcP7H7hQfeQUh3jPQJehAT12%3DfbBfArNmgU8qTc2B%2BYw%40mail.gmail.com.
