Thanks, André We had the user rename the branch instead and that seemed to work. Your fix looks fine (though I'm also not able to test it) so hopefully the devs will put it into a release in the future.
~Rob On Wed, Feb 12, 2020 at 3:59 AM André Klitzing <[email protected]> wrote: > Hi, > > seems your branch name needs url encoding. Maybe you could try this > quickfix. > I did not test it as I don't have a development environment at the moment. > So sorry if it throws errors. > > diff --git a/reviewboard/scmtools/hg.py b/reviewboard/scmtools/hg.py > index bbf70cd7c..1e3fca175 100644 > --- a/reviewboard/scmtools/hg.py > +++ b/reviewboard/scmtools/hg.py > @@ -378,7 +378,8 @@ class HgWebClient(SCMClient): > if start: > query_parts.append('ancestors(%s)' % start) > > - query_parts.append('branch(%s)' % (branch or '.')) > + import urllib.parse > + query_parts.append('branch(%s)' % > (urllib.parse.quote_plus(branch) or '.')) > > query = '+and+'.join(query_parts) > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "Review Board Community" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/reviewboard/vdmj1o_moY8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/81cc588e-c12d-4ff5-a76b-466603cbc942%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/81cc588e-c12d-4ff5-a76b-466603cbc942%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- <https://about.me/robpetti?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb> Rob Petti about.me/robpetti <https://about.me/robpetti?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CABH9TsJ8enkBp_%3DD2z70FxdEWbNF8OhvgqvGJW1NrDWjrpupfg%40mail.gmail.com.
