Hello all!

We're trying to swtich to ReviewBoard from JetBrains Upsource, and we're 
attempting to do some post-commit reviews.

The error we're seeing from rbt post happens during the 'validating 
commits' stage, and it fails with Error Validating Diff

You can replicate this with a mercurial repository via the following steps:

Setup:

   - Create a new branch
   - Change any file in the repository, and commit
   - Add 2 new files (i.e.  myfile1 and myfile2), hg add and hg commit
   - Change the first new file and hg commit
   - Change the 2nd new file and hg commit
   - hg push --new-branch


Attempt to create a new review request with rbt post (the revision IDs are: 
parent of first commit on this branch, and most recent commit on this 
branch):
rbt post --branch `hg branch` -p --target-groups my-review-group --summary 
"testing" --description "testing" --tracking-branch default f638ab41e9fc 
438b21c0ba39

We see the following output:
Validating commits... ███████████████████████████████████████             
 [3/4]
ERROR: Error validating diff

rb_test/myfile2.txt: The file was not found in the repository. (HTTP 400, 
API Error 207)


What are we doing wrong? 

Our standard workflow is to create a new branch (for bugfix or new 
feature), make code changes/additions/etc with commits along the way, push 
the branch and then request a Review.  Should we change our process? If so, 
what is the best-practice for ReviewBoard?


Any help or insight you can provide would be greatly appreciated.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/4ddd2df2-6227-44b2-abd4-0278e7c661d4n%40googlegroups.com.

Reply via email to