Hi, Yep, upgrading Mercurial *should* address it. I don't recall if there's optional support that needs to be added to Mercurial to enable that endpoint, but that's why you're not seeing the commit browsing turn up.
The string we look for was correct on the versions we initially tested, but it may not have been comprehensive. We can update that to look for variations for sure, and get that into 5.0.5. Christian On Mon, May 8, 2023 at 2:56 PM Astro Jetson <[email protected]> wrote: > Thanks Christain, > > And that bad data would be: "not yet implemented". > > It looks like reviewboard 5.0.4 is using an end point introduced after our > admittedly very out-of-date 3.8.3 Mercurial repos. > > I found this bug report: https://hellosplat.com/s/beanbag/tickets/4524/, > which seems to indicate the issue is addressed. The changes are reviewed > here: https://reviews.reviewboard.org/r/8778/diff/4/ These were released > in rb 2.5.x > > it looks like the code in hg.py is looking for 'not yet implemented' instead > of '"not yet implemented"' in _get_http_json. > > The bug report is about versions < Mercurial 3.9. Will upgrading past > 3.9.x address this issue? > > On Thursday, May 4, 2023 at 1:20:42 AM UTC-4 Christian Hammond wrote: > >> Looks like the JSON endpoint Review Board is trying to hit on the >> Mercurial server is returning some raw string and not JSON data. >> >> Check the configured URL for that repository, and then go to the >> following url: >> >> https://<repository url>/json-log/ >> >> See what that shows. If you get something that looks like JSON data, try: >> >> https://<repository >> url>/json-log/?rev=ancestors(9436e8d540ab26ab7f95a93731829ab2b5f55b83)+and+branch(default) >> >> That's the URL that Review Board most likely tried to hit that returned >> the bad data. >> >> Christian >> >> On Wed, May 3, 2023 at 1:55 PM Astro Jetson <[email protected]> >> wrote: >> >>> Hi, >>> >>> We are seeing a 500 Error when on the "New Review Request" page after >>> selecting any repository. Our Mercurial servers are 3.8.3, served with >>> apache + wsgi and hgserve. The URLs for our repos are always http://. >>> >>> The error is: string indices must be integers. Error dump is attached. >>> >>> [image: rbrd01-500-CreateReview.png] >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Review Board Community" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/reviewboard/bf54ae35-19c6-45e4-bf60-d64fe61963f8n%40googlegroups.com >>> <https://groups.google.com/d/msgid/reviewboard/bf54ae35-19c6-45e4-bf60-d64fe61963f8n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/1c723913-65da-4034-95a2-aa4fb5c47c17n%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/1c723913-65da-4034-95a2-aa4fb5c47c17n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7Vndn4vrhju8FkzWKW5FWBz2EiTKdaP2ovwbd%2B7b0GvLJvLA%40mail.gmail.com.
