----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44509/#review122514 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 111) <https://reviews.apache.org/r/44509/#comment184560> In general it is safer to write "cluster-env".equals(configType) It prevents NPE when configType is null. Probably in this case configType is never null, so it is not an issue, just a remark. - Daniel Gergely On márc. 8, 2016, 1:42 du, Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44509/ > ----------------------------------------------------------- > > (Updated márc. 8, 2016, 1:42 du) > > > Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sandor Magyari. > > > Bugs: AMBARI-15336 > https://issues.apache.org/jira/browse/AMBARI-15336 > > > Repository: ambari > > > Description > ------- > > This issue was originally addressed by > https://issues.apache.org/jira/browse/AMBARI-14745 however a corner case is > not being handled in that fix. > > If a Blueprint is being used where configurations are specified solely within > host groups than the orphaned configuration types were missed from removal. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > a995a3b > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java > 3ed8ed5 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java > 156580a > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 69c1935 > > Diff: https://reviews.apache.org/r/44509/diff/ > > > Testing > ------- > > 1.Unitest have been modified to cover this corner case as well. > > 2. Manual testing with Blueprints having configurations only in host groups. > > > Thanks, > > Sebastian Toader > >
