----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44459/#review122524 -----------------------------------------------------------
Ship it! Ship It! - Oliver Szabo On March 8, 2016, 2:52 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44459/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 2:52 p.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sandor Magyari. > > > Bugs: AMBARI-15316 > https://issues.apache.org/jira/browse/AMBARI-15316 > > > Repository: ambari > > > Description > ------- > > When generating accounts in an Active Directory, it may be useful to add a > unique value to CN's. In the past generating this value was done by taking > the SHA1 hash of the relevant normalized principal name. For example > {{[email protected]}} yields > {{d9b48cb1c075d3da9fab4855a4031266bab8fb6a}}. > > Because using SHA1 at all may not be desirable, Ambari should provide options > to use the following digest algorithms in the Active Directory account > creation attribute template ({{kerberos-env/ad_create_attributes_template}}: > > Attribute Variables |Example > ---------------------|------------------------------------------ > $principal_digest |SHA1 hash of the $normalized_principal > $principal_digest_256|SHA256 hash of the $normalized_principal > $principal_digest_512|SHA512 hash of the $normalized_principal > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java > a1e1544 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java > 0622807 > > Diff: https://reviews.apache.org/r/44459/diff/ > > > Testing > ------- > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:07:01.482s > [INFO] Finished at: Mon Mar 07 12:47:02 EST 2016 > [INFO] Final Memory: 58M/799M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:31 h > [INFO] Finished at: 2016-03-08T00:56:43+00:00 > [INFO] Final Memory: 140M/492M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
