> On March 9, 2016, 8:17 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py,
> >  line 62
> > <https://reviews.apache.org/r/44542/diff/2/?file=1292928#file1292928line62>
> >
> >     What happens now if PXF is in started state?
> >     
> >     Ideally when you do a restart:
> >     - if PXF is already in started state, do stop and start
> >     - if PXF is already in stopped state, do start

pxf has restart method which is used for starting it. the method name is start 
which call it. Dropping the issue.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44542/#review122791
-----------------------------------------------------------


On March 9, 2016, 4:32 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44542/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 4:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15341
>     https://issues.apache.org/jira/browse/AMBARI-15341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch updates the method used to restart PXF.
> We should use pxf-service restart method when Restart action is called via 
> Ambari.
> Currently we use pxf-service stop followed by pxf-service start, due to which 
> if pxf-service is already stopped, stop command fails.
> pxf-service restart takes care of not exiting with exit code 1 if pxf-service 
> is already stopped, and finishes successfully.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py
>  9a1eaf3 
> 
> Diff: https://reviews.apache.org/r/44542/diff/
> 
> 
> Testing
> -------
> 
> yes. manually
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to