----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44174/#review122910 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Март 10, 2016, 10:46 д.п., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44174/ > ----------------------------------------------------------- > > (Updated Март 10, 2016, 10:46 д.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro > Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15228 > https://issues.apache.org/jira/browse/AMBARI-15228 > > > Repository: ambari > > > Description > ------- > > Ambari is overriding permissions on default HDFS directories such as /app- > logs, /apps/hive/warehouse, /tmp. > This is allowing any user to write in those locations preventing them from > having control via Ranger/HDFS > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > ed9a642 > > ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py > 06d0f2b > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 2ae4a80 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d85f17e > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 157b961 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 43aba04 > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > bc90a8c > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > 09af8a9 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > acc0fcb > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > 5f942f6 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 6c8d5ff > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 7564905 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 50a8fda > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 04ab4c8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > 34bb032 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > d61dc2e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 8079631 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 6ec3996 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 078900e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > b619b78 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc46749 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 9d4847f > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py > b261b23 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > 0073865 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py > 17998c6 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > 1dbed45 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py > 132ff77 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py > 52c78c5 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 94988ce > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py > f0ba617 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > f30b807 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml > 59d4964 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 8d7427d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > a939302 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml > b444c11 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 64094c0 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml > 3059db6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 9c2a8bf > > ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py > 9670b1c > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > 8de7f96 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2f1f66c > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py > b28d991 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 14e88d6 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 2d790f8 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > 1c854b5 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py > ef187bd > ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py > 386e5c9 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 3ff4d73 > > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py > 8056aae > ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json > e45303d > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > d3f7f15 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json > 92d2052 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json f35e8f7 > > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json > 1b0a995 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json > dd932d3 > ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json > 1918606 > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json > 33270ce > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json > 6f1aef1 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json > a0beca9 > ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json > f2ec21b > ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json > cec5431 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json > 3acc31b > ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json ce49e37 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 4f81af8 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json > 8da4816 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_active_node.json > adb97c9 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node.json > 40e18d2 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start.json > b9e3b44 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json a0a2ee0 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json 5799708 > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json 209651d > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json > bb9a3a2 > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-preupgrade.json > adac072 > > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2-phoenix.json > fea5e34 > ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json > 71af43a > ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json > c44f29c > ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json > e825dd3 > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json 6160b6a > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu_standby.json > 576288c > ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 5ae0ff2 > ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json > 9e21d9b > > ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json > f92d24f > > ambari-server/src/test/python/stacks/2.0.6/configs/rebalancehdfs_default.json > 34ffede > > ambari-server/src/test/python/stacks/2.0.6/configs/rebalancehdfs_secured.json > a868eeb > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 42336f7 > ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json > 6b7dabc > ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json > 5913b3e > > ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json > f3defee > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 36b0b3a > ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py a60a6a6 > ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py > ea0cfba > ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json > df13b43 > ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json > bfde096 > ambari-server/src/test/python/stacks/2.1/configs/default.json f02c485 > > ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json > 888666a > ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json > f9e518d > ambari-server/src/test/python/stacks/2.1/configs/secured.json 1b0a80c > ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py > 8e8cda4 > ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py > 74e4c24 > ambari-server/src/test/python/stacks/2.2/configs/default.json 5fcfe1f > > ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json > a70f4c1 > ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json > 0a5f6e9 > ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json d70ab3f > > ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json > 8e9cded > ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json > 289ad5d > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 77b2662 > ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json > b9beed1 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 1c5f4bc > > ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json > 2cc66a6 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json > a13f50e > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json > d40a804 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json > 9fd16d3 > > ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json > a354d61 > ambari-server/src/test/python/stacks/2.2/configs/secured.json 06a67f3 > > ambari-server/src/test/python/stacks/2.2/configs/spark-job-history-server.json > ea617fa > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 7bd50ea > > ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py > cb7b13b > ambari-server/src/test/python/stacks/2.3/SPARK/test_spark_thrift_server.py > b8ac3f8 > ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py 90ae6c0 > ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json 2ae9584 > ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json > db157af > ambari-server/src/test/python/stacks/2.3/configs/default.json 62fa6b6 > ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json abe3559 > ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json f560704 > ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 3a8133a > ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json e2853b7 > ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8 > ambari-server/src/test/python/stacks/2.3/configs/storm_default.json 2de83a8 > ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json > 3b92500 > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java > d774ab8 > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java > 291a2d9 > > Diff: https://reviews.apache.org/r/44174/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
