-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44723/#review123235
-----------------------------------------------------------


Ship it!




Ship It!

- Xi Wang


On March 11, 2016, 2:17 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44723/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 2:17 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15394
>     https://issues.apache.org/jira/browse/AMBARI-15394
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Due to case that service has the same key with its component (e.g. Pig), 
> App.format.role() needs a second parameter to know which it should return.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> 4156e46 
>   
> ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step3_controller.js
>  8a99b1e 
>   
> ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step4_controller.js
>  05f4ff7 
>   
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js
>  d612821 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js
>  15c0701 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
>  404c54c 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
>  6562f3f 
>   
> ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step4_controller.js
>  7685802 
>   ambari-web/app/controllers/main/admin/kerberos/step3_controller.js 9377a5b 
>   ambari-web/app/controllers/main/admin/service_auto_start.js a4d607a 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 3e1291d 
>   ambari-web/app/controllers/main/charts/heatmap.js aacb8e5 
>   ambari-web/app/controllers/main/host.js ec745e7 
>   ambari-web/app/controllers/main/host/details.js bbd1bf7 
>   ambari-web/app/controllers/main/service/add_controller.js b755f55 
>   ambari-web/app/controllers/main/service/item.js f37891d 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 91929f5 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> c06a2ea 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> 8a1b647 
>   ambari-web/app/controllers/wizard.js 0f7dbe6 
>   ambari-web/app/controllers/wizard/step10_controller.js d12b6c5 
>   ambari-web/app/controllers/wizard/step6_controller.js d3f73ef 
>   ambari-web/app/controllers/wizard/step8_controller.js 27374b9 
>   ambari-web/app/controllers/wizard/step9_controller.js 791adb1 
>   ambari-web/app/mappers/configs/config_groups_mapper.js f5df389 
>   ambari-web/app/mappers/service_metrics_mapper.js 9d5c155 
>   ambari-web/app/mixins/common/configs/configs_saver.js 4f1952c 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 0480c0b 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 674db2c 
>   ambari-web/app/mixins/wizard/assign_master_components.js 4fe5d95 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js 0119f06 
>   ambari-web/app/models/alerts/alert_definition.js 6c25f7e 
>   ambari-web/app/models/configs/service_config_version.js 1315ff7 
>   ambari-web/app/models/root_service.js b5d703b 
>   ambari-web/app/models/service.js 8546812 
>   ambari-web/app/models/stack_service.js dbfabc0 
>   ambari-web/app/utils/batch_scheduled_requests.js eb783cc 
>   ambari-web/app/utils/ember_computed.js ecab9a2 
>   ambari-web/app/utils/helper.js ec2dc42 
>   ambari-web/app/utils/host_progress_popup.js 767bf2f 
>   ambari-web/app/views/common/rolling_restart_view.js 5410e0b 
>   ambari-web/app/views/main/admin/stack_upgrade/failed_hosts_modal_view.js 
> d577e11 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 
> d853bd8 
>   ambari-web/app/views/main/charts/heatmap/heatmap_host.js 544ad85 
>   ambari-web/app/views/main/host.js 5f337da 
>   ambari-web/app/views/main/host/combo_search_box.js c1d00f4 
>   ambari-web/app/views/main/host/hosts_table_menu_view.js 5670814 
>   ambari-web/app/views/main/host/summary.js aa12581 
>   ambari-web/app/views/main/service/info/configs.js 44c2455 
>   ambari-web/app/views/main/service/info/summary.js 2482913 
>   ambari-web/app/views/main/service/item.js 0e3c52b 
>   ambari-web/app/views/main/service/reassign/step4_view.js 91123bb 
>   ambari-web/app/views/main/service/reassign/step6_view.js 9ebc235 
>   ambari-web/app/views/wizard/step6_view.js e8ae176 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 8dfd398 
>   ambari-web/test/controllers/wizard/step4_test.js e88f4c3 
>   ambari-web/test/utils/ember_computed_test.js 3a22f99 
>   ambari-web/test/utils/helper_test.js 2b43f28 
> 
> Diff: https://reviews.apache.org/r/44723/diff/
> 
> 
> Testing
> -------
> 
> Modified unit test. Local ambari-web test passed.
> 10466 tests complete (10 seconds)
> 121 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to