> On March 14, 2016, 4:09 p.m., Goutam Tadi wrote: > > ambari-web/app/mixins/common/configs/enhanced_configs.js, line 192 > > <https://reviews.apache.org/r/44769/diff/1/?file=1296964#file1296964line192> > > > > How about ```for each ``` instead of ``` for ``` ?
Any advantages that we will get from using each instead of for ? p.s. for is faster than each - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123438 ----------------------------------------------------------- On March 14, 2016, 3:59 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44769/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 3:59 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr > Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, > Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-15396 > https://issues.apache.org/jira/browse/AMBARI-15396 > > > Repository: ambari > > > Description > ------- > > As part of AMBARI-15189, dfs.allow.truncate was set to true if HAWQ service > is being installed. However, the recommendation is getting cleared in > ambari-web because HDFS is already installed. > > > Diffs > ----- > > ambari-web/app/mixins/common/configs/enhanced_configs.js 1ee4526 > > Diff: https://reviews.apache.org/r/44769/diff/ > > > Testing > ------- > > Tested manually with and without HAWQ. > > > Thanks, > > Lav Jain > >
