----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44933/#review124298 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml (line 24) <https://reviews.apache.org/r/44933/#comment186772> Actually, this file must exist for the entire stack and not inside the #.# folder. The reason being that an EU from HDP 2.1 to 2.3 does the following: 1. Current stack is 2.1 2. Stop all services 3. Change stack to 2.3 and save new configs 4. Start all services on 2.3 Any action before step 3 may need to reference the stack_features min_version and max_version of the newer stack it is going to. But that will of course be inaccessible at that time. So we need a single file for the entire stack name. - Alejandro Fernandez On March 16, 2016, 9:24 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44933/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 9:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-14435 > https://issues.apache.org/jira/browse/AMBARI-14435 > > > Repository: ambari > > > Description > ------- > > Apply the stack featurization prototype detailed on AMBARI-13364 to > ZOOKEEPER service. > This patch removes the hardcoded stack versions in ZK common-services code > (centralized version and parameterized stack configurations will be faced in > other JIRAS) > stack_features is now a property in .json format in > configuration/cluster-env.xml for each stack version. > With the structure: > { > "stack_features": [ > { "name": "feature1", "description" : "Feature1 support", "min_version" : > "Y.Y.Y.Y" , "max_version" : "X.X.X.X"} > , > ... > ] > } > where min_version/max_version are optional constraints. > New resource_management/libraries/functions/stack_fetaures.py has been > introduced to parse the json file and called from service code to check if > the stack supports the required feature. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py > 9ff9125 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py > d18e4d7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py > 5712ce4 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py > 25ace24 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py > d5b6898 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py > 6fe0772 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 3fb82e9 > > ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml > f1fa4de > > ambari-server/src/main/resources/stacks/HDP/2.3/configuration/cluster-env.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/44933/diff/ > > > Testing > ------- > > Zookeeper fresh installation has been tested using HDP stack 2.3 and > AMBARI-13364 branch code. > > > Thanks, > > Juanjo Marron > >
