-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44941/
-----------------------------------------------------------

(Updated March 17, 2016, 1:09 a.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Changes
-------

- Added swap_in and swap_out
- Fixed memory used to reflect (used - cached)


Bugs: AMBARI-15448
    https://issues.apache.org/jira/browse/AMBARI-15448


Repository: ambari


Description
-------

We need to collect and expose per-disk metrics from AMS for iostats counters.
We can sort the disk names alphabetically, and name the metrics like _1, _2, 
etc.

Plus from psutils:
busy_time: (Linux, FreeBSD) time spent doing actual I/Os (in milliseconds)
read_merged_count (Linux): number of merged reads (see iostat doc)
write_merged_count (Linux): number of merged writes (see iostats doc)

_Additional fixes_:
- Combined_disk_total metric seems to be wrong : it is a sum() of all disk 
percentages from different disks
- Missing ATS and JHS metrics due to wrong config item in 
hadoop-metrics2.properties file
- Report number of disks


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 a053955 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c04a61b 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
2e8c442 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/metric_collector.py
 c28fd03 
  
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py
 f07b573 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 e5020a5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 0b0932a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
 47b504f 

Diff: https://reviews.apache.org/r/44941/diff/


Testing
-------

Manually verified.

----------------------------------------------------------------------
Ran 12 tests in 0.020s

OK
----------------------------------------------------------------------
Total run:12
Total errors:0
Total failures:0
OK


Thanks,

Sid Wagle

Reply via email to