-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45030/#review124198
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 (line 135)
<https://reviews.apache.org/r/45030/#comment186639>

    Instead of 'special' can we call this something more meaningful; like 
`BIND_ALL_IP_ADDRESS`?


- Jonathan Hurley


On March 18, 2016, 9:45 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45030/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 9:45 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15480
>     https://issues.apache.org/jira/browse/AMBARI-15480
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need collector hostname in configs. 
> Replace 0.0.0.0 with hostname in 
> ams-site/timeline.metrics.service.webapp.address
> Implement changes for blueprints, stack_advisor, upgrade catalog
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  e73e38f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  e10585e 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  3b8505b 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  45c1811 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  12c0f25 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  5ec879c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  b517eeb 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  f75d578 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  a022282 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  7a023cf 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> ee2007f 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  469e709 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  ef5dc76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  859513b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json fe92b5b 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> 688dbe0 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 4648ffc 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 9b2da28 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  68afb68 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> 79c5580 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> a7057db 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> 390f9ce 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json 3fe1235 
> 
> Diff: https://reviews.apache.org/r/45030/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to