> On March 14, 2016, 5:10 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 140
> > <https://reviews.apache.org/r/44688/diff/1/?file=1295170#file1295170line140>
> >
> >     Check for null (i.e. no active namenode)
> 
> bhuvnesh chaudhary wrote:
>     Thanks for review Jayush,
>     
>     I was testing the behavior when the Namenode is down to essentially test 
> for no active namenode, and 
> https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L135-L143
>  handles if the active_namenode identified is an empty list, and returns 
> UnknownConfiguration(..) if none is found which handles the null / empty case 
> ? So, thought not to handle it here again.
>     
>     On the other hand, the response from get_active_namenode returned is 
> 'Configuration parameter 'fs_root' was not found in configurations 
> dictionary!' when no active namenode is found (i turned down HDFS), which is 
> kind of not explanatory, do you think we should make this as an exception in 
> a separate jira ?
> 
> bhuvnesh chaudhary wrote:
>     Jayush, Let me know if there is any concern if i drop the issue based on 
> the response provided up.

Dropping the issue and will merge it. Will revisit in case needed.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44688/#review123456
-----------------------------------------------------------


On March 11, 2016, 1:26 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44688/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 1:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15380
>     https://issues.apache.org/jira/browse/AMBARI-15380
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PXF alerts are not working on secured HDFS HA clusters. When the cluster is 
> HA, Active Namenode should be used to get the delegation token for pxf, 
> however currently it goes to localhost.
> Updated the logic to find out the active namenode and use it.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  871da2b 
> 
> Diff: https://reviews.apache.org/r/44688/diff/
> 
> 
> Testing
> -------
> 
> yes. manually.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to