-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44923/
-----------------------------------------------------------

(Updated Березень 17, 2016, 9:28 після полудня)


Review request for Ambari, Dmytro Sen and Jonathan Hurley.


Bugs: AMBARI-15445
    https://issues.apache.org/jira/browse/AMBARI-15445


Repository: ambari


Description
-------

For some alerts, having the ability to include a link in the response would be 
incredibly beneficial.  Having a structured response format would allow alert 
creators to add links that operators could click on to help give more context 
around an alert, or point to a remediation step.  Something like:

{code}
{
  "response": "There were more than 5 soft limits reached in the past 10 
minutes.  Please click the link to see the log file.",
  "href": "http://some.server/other/stuff";
}
{code}


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 0f73ec6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
 9e21bec 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity_.java
 d2d4cf3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
 9fff5f2 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
 3b4f5fc 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 a803f73 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql a85202d 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9b4810c 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql cc3d197 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 07c786d 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
ab6dc93 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8e91fde 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 440ca44 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
 d44b7c8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7f3b80c 

Diff: https://reviews.apache.org/r/44923/diff/


Testing
-------

Tests will be added after patch draft review


Thanks,

Vitalyi Brodetskyi

Reply via email to