-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44880/#review124069
-----------------------------------------------------------




ambari-web/app/messages.js (line 3019)
<https://reviews.apache.org/r/44880/#comment186416>

    Small grammar correction - 
    
    Instead of:
    "UI is stuck and wont loaded, etc)." 
    It should be
    "UI is stuck and wont load, etc.)."



ambari-web/app/templates/experimental.hbs (line 52)
<https://reviews.apache.org/r/44880/#comment186417>

    The UI shows a blue button under the table which gives the impression the 
button acts on the table. My suggestion would be to have a divider (<hr>) 
seperating table and button. The button should be under the divider and also in 
red color as its a dangerous action to perform.


- Srimanth Gunturi


On March 17, 2016, 1:13 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44880/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 1:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15436
>     https://issues.apache.org/jira/browse/AMBARI-15436
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently Ambari UI persists it's current state on the server. This helps 
> when a different user logs in, they end up in the same UI. Sometimes however, 
> UI's state persisted on server does not sync with cluster state, thereby 
> putting UI in a broken state with no recourse for the stuck user.
> 
> Ambari UI should provide a _Reset UI_ button in the experimental page which 
> resets the UI state on server.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/experimental.js 9fa6da5 
>   ambari-web/app/mappers/server_data_mapper.js 1e08161 
>   ambari-web/app/messages.js 9289fc2 
>   ambari-web/app/templates/experimental.hbs 2873679 
> 
> Diff: https://reviews.apache.org/r/44880/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 24578 tests complete (23 seconds)
> 145 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to