> On Март 18, 2016, 3:29 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 135
> > <https://reviews.apache.org/r/45030/diff/1/?file=1305237#file1305237line135>
> >
> >     Instead of 'special' can we call this something more meaningful; like 
> > `BIND_ALL_IP_ADDRESS`?

Done.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45030/#review124198
-----------------------------------------------------------


On Март 18, 2016, 3:33 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45030/
> -----------------------------------------------------------
> 
> (Updated Март 18, 2016, 3:33 п.п.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15480
>     https://issues.apache.org/jira/browse/AMBARI-15480
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need collector hostname in configs. 
> Replace 0.0.0.0 with hostname in 
> ams-site/timeline.metrics.service.webapp.address
> Implement changes for blueprints, stack_advisor, upgrade catalog
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  f5e7578 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  84bb9f3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  a21035e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  99e97f7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  12c0f25 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  29f71a7 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  b32aedf 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  d3a0606 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  ab935a1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  7153c54 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> ef82bce 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  469e709 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d5755 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  acbf055 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json b23d4b9 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> 688dbe0 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 6d92182 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 921ee23 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  a43f15a 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> 59cd868 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> 481b6d4 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> 200ad23 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json 3fe1235 
> 
> Diff: https://reviews.apache.org/r/45030/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to