-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44916/
-----------------------------------------------------------

(Updated March 16, 2016, 4:55 p.m.)


Review request for Ambari, Dmytro Sen, Jonathan Hurley, Nate Cole, and Sid 
Wagle.


Changes
-------

Added NPE protection in Kerberos and Blueprint logic for recommended 
configrations.  Updated test case to provided null values for property maps.


Bugs: AMBARI-15442
    https://issues.apache.org/jira/browse/AMBARI-15442


Repository: ambari


Description
-------

The StackAdvisor needs to set a config map for the `ams-grafana-env`, even it 
is empty, to meet non-null expectations in Kerberos and Blueprint logic. 

To to this, the following line needs to be added to the StackAdvisor code:

#stacks/HDP/2.0.6/services/stack_advisor.py:473
```
putGrafanaProperty = self.putProperty(configurations, "ams-grafana-env", 
services)
```


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
 ea9fffb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 be6edc9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 f5e7578 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
8c18421 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java
 c4e694b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 f6027f3 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 68d5755 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9070c0a 

Diff: https://reviews.apache.org/r/44916/diff/


Testing
-------

Manually tested in cluster Kerbrerized using the Ambari UI.


Thanks,

Robert Levas

Reply via email to