-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45101/#review124552
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (lines 1437 - 1438)
<https://reviews.apache.org/r/45101/#comment187165>

    We chould not hardcode config types here.
    Simple way to make this dynamic is to use following method:
    org.apache.ambari.server.state.cluster.ClusterImpl#getServiceByConfigType
    
    So after adding this method to Cluster interface check will look like 
following:
    
    if ( cluster.getServiceByCOnfigType != null && 
clusterConfig.getServiceConfigVersions().isEmpty() )


- Myroslav Papirkovskyy


On Березень 21, 2016, 4:23 після полудня, Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45101/
> -----------------------------------------------------------
> 
> (Updated Березень 21, 2016, 4:23 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-15489
>     https://issues.apache.org/jira/browse/AMBARI-15489
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The logic that determines if a new version has to be created for a 
> configuration should skip cluster wide config types when verifying current 
> desired config against service configs as these are not service configs.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ac2fb22 
> 
> Diff: https://reviews.apache.org/r/45101/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> Unit tests results:
> Results :
> 
> Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Reply via email to