> On March 21, 2016, 8:01 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py, > > line 40 > > <https://reviews.apache.org/r/44933/diff/1/?file=1301830#file1301830line40> > > > > Add constants to > > ambari/ambari-common/src/main/python/resource_management/libraries/functions/constants.py > > > > class StackFeatures: > > ROLLING_UPGRADE = "rolling_upgrade"
Added new review request with all the new design changes: https://reviews.apache.org/r/45141/ Im not sure how is the right procedure in this case, but it was hard to me to keep track of the diff changes after the new prototype design - Juanjo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44933/#review124636 ----------------------------------------------------------- On March 22, 2016, 1:03 a.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44933/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 1:03 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-14435 > https://issues.apache.org/jira/browse/AMBARI-14435 > > > Repository: ambari > > > Description > ------- > > Apply the stack featurization prototype detailed on AMBARI-13364 to > ZOOKEEPER service. > This patch removes the hardcoded stack versions in ZK common-services code > (centralized version and parameterized stack configurations will be faced in > other JIRAS) > stack_features is now a property in .json format in > configuration/cluster-env.xml for each stack version. > With the structure: > { > "stack_features": [ > { "name": "feature1", "description" : "Feature1 support", "min_version" : > "Y.Y.Y.Y" , "max_version" : "X.X.X.X"} > , > ... > ] > } > where min_version/max_version are optional constraints. > New resource_management/libraries/functions/stack_fetaures.py has been > introduced to parse the json file and called from service code to check if > the stack supports the required feature. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py > 9ff9125 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py > d18e4d7 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py > 5712ce4 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py > 25ace24 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py > d5b6898 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py > 6fe0772 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 3fb82e9 > > ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml > f1fa4de > > ambari-server/src/main/resources/stacks/HDP/2.3/configuration/cluster-env.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/44933/diff/ > > > Testing > ------- > > Zookeeper fresh installation has been tested using HDP stack 2.3 and > AMBARI-13364 branch code. > > > Thanks, > > Juanjo Marron > >
