-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/#review124774
-----------------------------------------------------------




contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
8)
<https://reviews.apache.org/r/44700/#comment187436>

    Try to give a space after #. Just from the conventions point of view.


- DIPAYAN BHOWMICK


On March 22, 2016, 10:20 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44700/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 10:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14084
>     https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Earlier : 
> logs of all the views used to go into ambari-server.log which caused problem 
> in debugging views.
> 
> In this Patch:
> ViewRegistry now looks for file
>  view.log4j.properties using the view archive classloader and loads all the
>  log4j properties in it using PropertyConfigurator. Separate log4j
>  configuraiton files added to all core views.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 6a01351 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 144926a 
>   contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
>   contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
>   contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
>   contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
>   contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
>   contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
>   contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 
> 
> Diff: https://reviews.apache.org/r/44700/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing Done.
> separate log files for each view was properly generated. Also the log level 
> was getting properly set.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Reply via email to