----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43049/#review124829 -----------------------------------------------------------
ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 338) <https://reviews.apache.org/r/43049/#comment187524> This should be in a function to avoid duplicating code. Or at a minimum, include a comment in both places indicating the other location to change. - Alejandro Fernandez On March 22, 2016, 2:57 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43049/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 2:57 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-14863 > https://issues.apache.org/jira/browse/AMBARI-14863 > > > Repository: ambari > > > Description > ------- > > After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie- > server/libext > Oozie war should be updated. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > c503a38 > ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > 407bb2f > > Diff: https://reviews.apache.org/r/43049/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
