> On March 22, 2016, 7:01 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java, > > line 32 > > <https://reviews.apache.org/r/45150/diff/3/?file=1309923#file1309923line32> > > > > Why create a new TreeMap?
Ignoring this since this method is not used currently. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45150/#review124856 ----------------------------------------------------------- On March 22, 2016, 7:44 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45150/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 7:44 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15476 > https://issues.apache.org/jira/browse/AMBARI-15476 > > > Repository: ambari > > > Description > ------- > > Fix TimelineMetricAggregatorSecond such that time slices with no datapoints > for a series are given interpolated values based on nearby values. > > Change METRIC_RECORD TTL to 2 days in distributed mode. > > Add stack advisor recommendation for AMS HBase log directory based on AMS log > directory. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java > PRE-CREATION > > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > aa12735 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java > e8e16a7 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > 6c8d153 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > b99d1f9 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > 7a8984a > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 61aa2ba > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 599ac3e > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 41da868 > > Diff: https://reviews.apache.org/r/45150/diff/ > > > Testing > ------- > > Manual testing done. > > Added unit tests. > > > Thanks, > > Aravindan Vijayan > >
